Hi, The string doesn't have to be changed in order to provide more info by the exception. A new field could be added to com.jcraft.jsch.JSchException to inform which method has failed. Another option is to extend the exception with a more informative type, leaving the current message intact. IMO the former is a better option.
BTW, where is the source code of JSch located? I tried to checkout it from :pserver:anonym...@jsch.cvs.sourceforge.net:/cvsroot/jsch but the repo seems to be empty http://jsch.cvs.sourceforge.net/viewvc/jsch/ Cheers, -- Tomasz Zarna Staff Software Engineer IBM SWG Lab, Cracow, Poland From: Stephen Williams <swill...@cup.hp.com> To: Tomasz Zarna/Poland/IBM@IBMPL Cc: jsch-users@lists.sourceforge.net, Atsuhiko Yamanaka <y...@jcraft.com> Date: 2011-09-29 15:24 Subject: Re: [JSch-users] Supply more meaningful exception messages Hi, I posted this question quite some years ago now. Atsuhiko responded at the time that too many people's code depends on this string, so it would cause problems for many if it were to be changed. And in fact my own code simply checks for "Auth fail" and provides a more verbose error message to users when "Auth fail" is encountered. So my own code would break if that message were changed (though it would probably simply post the new version of the message, which would be acceptable; but others may do more upon matching that string than simply providing a more verbose message). Regards, --Steve On 9/29/2011 3:50 AM, Tomasz Zarna wrote: > Hi again, > > A follow up to my previous post: > > +-From: Tomasz Zarna<tomaszza...@pl.ibm.com> -- > |[...] for our case, if > | com.jcraft.jsch.Session#connect(int) threw JSchException with more > info > | then just "Auth fail" this would be an improvement. A code (enum) for > the > | auth method that failed would be handy. > > Atsuhiko, does the idea make any sense to you? Do you plan any work on > this? > > How do you handle contributions to the project? I'm asking just in case, if > I had a patch would it be reviewed at least ? > -- > Tomasz Zarna > Staff Software Engineer > IBM SWG Lab, Cracow, Poland > > > > From: y...@jcraft.com (Atsuhiko Yamanaka) > To: Tomasz Zarna/Poland/IBM@IBMPL > Cc: jsch-users@lists.sourceforge.net > Date: 2011-09-13 08:17 > Subject: Re: [JSch-users] Supply more meaningful exception messages > > > > Hi, > > Thank for your notification, I had not checked that tracker. > > +-From: Tomasz Zarna<tomaszza...@pl.ibm.com> -- > |_Date: Mon, 12 Sep 2011 14:13:53 +0200 ________ > | > |I've already commented on the feature request from the subject, but I > hope > |you don't mind asking the same question here: > > |Do you have any plans to fix/improve this: > | > https://sourceforge.net/tracker/?func=detail&aid=1047646&group_id=64920&atid=509125 ? > > > What kind of exception message should be there in that case? > I think it is not good idea to put HOWTO instruction messages in > exceptions. > It is the role of applications using jsch. > > As for the problem you had, it had come from your example program. > If you had tried examples in http://www.jcraft.com/jsch/examples/ , > you did not, because those examples have implemented > the 'UIKeyboardInteractive' interface, by the default. > > > Sincerely, > -- > Atsuhiko Yamanaka > JCraft,Inc. > 1-14-20 HONCHO AOBA-KU, > SENDAI, MIYAGI 980-0014 Japan. > Tel +81-22-723-2150 > +1-415-578-3454 > Skype callto://jcraft/ > Twitter: http://twitter.com/ymnk > Facebook: http://facebook.com/aymnk > > > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2dcopy1 > _______________________________________________ > JSch-users mailing list > JSch-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jsch-users > > ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ JSch-users mailing list JSch-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jsch-users
