On Sun, Sep 27, 2009 at 5:59 PM, Steven Roussey <[email protected]> wrote: > > Yes, yes, agreed.
OK cool. For the rest of the patches, I looked at them but it's hard for me to tell what they are doing without examples and without a diff. So if there are ones you want me to look at it more detail please send a diff (via the codereview app). thanks, Andy > > On Sep 25, 12:42 am, Andy Chu <[email protected]> wrote: >> On Thu, Sep 24, 2009 at 3:51 PM, Steven Roussey <[email protected]> wrote: >> >> > default to whatever the user passed: >> >> > function _MakeTokenRegex(meta_left, meta_right) { >> > // TODO: check errors >> > return new RegExp('(' + >> > (META_ESCAPE[meta_left]||meta_left) + >> > '.+?' + >> > (META_ESCAPE[meta_right]||meta_right) + >> > '\n?)', 'g'); // global for use with .exec() >> > } >> >> Yes, the intention is to allow <% %> if you want. But I don't think >> it should be too hard to do in a principled way -- escape [ ] {} and >> other metacharacters if they appear anywhere. That is, {% %} should >> also work, but it doesn't with your fix. >> >> I guess a general regex escape is not really necessary, [] {} () are >> the real ones we want to take care of. >> >> Andy > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "JSON Template" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/json-template?hl=en -~----------~----~----~----~------~----~------~--~---
