[email protected] commented on revision
raf3d43ab2faeac07af235a2186e717f7fc26b784 in project json-template.
Details are at
http://code.google.com/p/json-template/source/detail?r=af3d43ab2faeac07af235a2186e717f7fc26b784
Line-by-line comments:
File: /javascript/json-template.js
(raf3d43ab2faeac07af235a2186e717f7fc26b784)
===============================================================================
Line 34: var metaFixes={}
-------------------------------------------------------------------------------
Also please name this variable so it's clear that it stores the memoized
results of EscapeMeta. escaped_meta would be a fine name.
Line 51: var str = '(' + EscapeMeta(meta_left) + '.*?' +
EscapeMeta(meta_right) + '\n?)';
-------------------------------------------------------------------------------
80 col
Respond to these comments at
http://code.google.com/p/json-template/source/detail?r=af3d43ab2faeac07af235a2186e717f7fc26b784
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "JSON
Template" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/json-template?hl=en
-~----------~----~----~----~------~----~------~--~---
