Hi Christoph,
Thanks for applying the patch :)
I've updated my svn copy and run the tests, right now there are 7 failures:
- testWhitespacesBeforeLists
- testFreeLinksKnowProtocols
- testFreeLinks
- testSecondLineListItem
- testCreoleStyleEscape
- testCreoleStyleEscape2
I think they cover all the issues I had found so far, but if I find
any new one I'll add a test.
On a different topic, if I understand it propertly the following
syntax would be valid in Creole to include a page within another:
{{Name of another page}}
Right now in CreoleFilter that syntax is always interpreted as a mean
to insert an attached image. I'd like to support both functionalities.
The key question is, how can we differentiate? There are two potential
solutions:
- Ask JSPWiki if a page with that name exists and if not interpret it
as an attachment. Is this possible at all?
- Implement a configurable check so that if the name ends with .png,
.jpg, etc. it's an image and otherwise it's a page.
I actually like the second more, since it allows showing a link to
upload the attachment or create the page if it doesn't exist yet.
Thougts?
Regards,
Jorge
On Wed, Mar 12, 2008 at 3:05 PM, Christoph Sauer <[EMAIL PROTECTED]> wrote:
> Hi Jorge, Hanno
> i've applied your patch and added a few more testcases for the know issues.
> Jorge, if you have more testcases, stuff that does not work like expected,
> it is the best to simply add them. Hanno, could you please take a look at
> them and try to fix them?
>
> Thanks!
>
> Christoph
>
> -----Ursprüngliche Nachricht-----
> Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im
> Auftrag von Jorge Ferrer
> Gesendet: Donnerstag, 28. Februar 2008 18:25
> An: Christoph Sauer
> Betreff: Working on CreoleFilter's known issues
>
>
>
> Hi Christoph,
>
> I've started studying the code of CreoleFilter and the JSPWiki parser
> trying to find the reason for the known bugs. I haven't had many
> advances yet. I'm particularly puzzled with the fact that regular URLs
> are not converted to links. I've confirmed that the filter doesn't
> modify it and JSPWiki by default does the conversion. Do you have any
> idea of what may be the reason?
>
> Also, I've made some changes to make the tests easier to run. I've
> made some slight changes to the tests themselves to make them run
> (extra spaces and more control of the loaded properties file). I've
> attached a patch. Could you take a look at apply it if you agree with
> it?
>
> Regards,
> Jorge
>
> On Fri, Feb 22, 2008 at 1:59 PM, Jorge Ferrer <[EMAIL PROTECTED]> wrote:
> > Thanks Christoph!
> >
> >
> >
> > On Fri, Feb 22, 2008 at 11:21 AM, Christoph Sauer <[EMAIL PROTECTED]>
> wrote:
> > > >One minor note. I think it would be better if the "build" directory
> > > >was not in SVN since it rebuilds it when compiling the sources and
> > > >causes the svn update command to complain the next time it's used.
> > >
> > > Yes, I always forget that when I check in a new project. I removed it
> and
> > > added it to svn.ignore
> > >
> > >
> > > --Christoph
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] Im
> > > Auftrag von Jorge Ferrer
> > > Gesendet: Mittwoch, 20. Februar 2008 20:41
> > >
> > >
> > > An: Christoph Sauer
> > > Betreff: Re: What is the status of the development to support Creole?
> > >
> > > Hi Christoph,
> > >
> > > Thanks, it now works. I've been able to download and compile from
> source.
> > >
> > > One minor note. I think it would be better if the "build" directory
> > > was not in SVN since it rebuilds it when compiling the sources and
> > > causes the svn update command to complain the next time it's used.
> > >
> > > I'll get back to you as soon as I'm able to get to work with some of
> > > my planned improvements.
> > >
> > > Regards,
> > > Jorge
> > >
> > > On Wed, Feb 20, 2008 at 7:01 PM, Christoph Sauer
> <[EMAIL PROTECTED]>
> > > wrote:
> > > > Try svn://141.7.56.28:8080/usr/local/repo/public, Standardports seem
> to be
> > > > blocked outside the university...
> > > >
> > > > --Christoph
> > > >
> > > >
> > > > -----Ursprüngliche Nachricht-----
> > > > Von: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]
> > > Im
> > > > Auftrag von Jorge Ferrer
> > > > Gesendet: Dienstag, 19. Februar 2008 18:20
> > > >
> > > >
> > > > An: Christoph Sauer
> > > > Betreff: Re: What is the status of the development to support
> Creole?
> > > >
> > > > Hi Christoph,
> > > >
> > > > I've been trying to checkout the sources from that URL but I cannot
> > > > access the IP address. When I do an 'svn co' it just waits until a
> > > > timeout expires and then throws an error saying "Could not reach
> > > > 141.7.56.28"
> > > >
> > > > Any ideas?
> > > >
> > > > Jorge
> > > >
> > > > On Feb 19, 2008 5:28 PM, Christoph Sauer <[EMAIL PROTECTED]>
> wrote:
> > > > > Hi Jorge,
> > > > >
> > > > > You can now checkout the project anonymously from
> > > > >
> > > > > svn://141.7.56.28/usr/local/repo/public
> > > > >
> > > > > I've updated the documentation accordingly at
> > > > > http://www.i3g.hs-heilbronn.de/Wiki.jsp?page=JSPWikiCreoleFilter
> > > > >
> > > > > Cheers
> > > > > Christoph
> > > > >
> > > > >
> > > > >
> > > > > -----Ursprüngliche Nachricht-----
> > > > > Von: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]
> > > Im
> > > > > Auftrag von Jorge Ferrer
> > > > > Gesendet: Dienstag, 19. Februar 2008 11:53
> > > > >
> > > > > An: Christoph Sauer
> > > > > Betreff: Re: What is the status of the development to support
> Creole?
> > > > >
> > > > > Hi Christoph,
> > > > >
> > > > > That's great news. For now all I need is read access. I'll let
> you
> > > > > decide if I deserve commit access or not based on the
> number/quality
> > > > > of the patches I'll send you.
> > > > >
> > > > > Thanks!
> > > > >
> > > > > Jorge
> > > > >
> > > > > On Feb 19, 2008 10:56 AM, Christoph Sauer <[EMAIL PROTECTED]>
> > > wrote:
> > > > > > Hi Jorge,
> > > > > >
> > > > > > we have our own SVN here, I just have to make some
> modifications
> > > (figure
> > > > > out
> > > > > > certificate authentication) and then will give you commit
> access, if
> > > you
> > > > > > like...
> > > > > >
> > > > > > Cheers
> > > > > > Christoph
> > > > > >
> > > > > > -----Ursprüngliche Nachricht-----
> > > > > > Von: [EMAIL PROTECTED]
> > > [mailto:[EMAIL PROTECTED]
> > > > Im
> > > > > > Auftrag von Jorge Ferrer
> > > > > > Gesendet: Montag, 18. Februar 2008 13:58
> > > > > > An: Christoph Sauer
> > > > > >
> > > > > > Betreff: Re: What is the status of the development to support
> Creole?
> > > > > >
> > > > > > Hi Christoph,
> > > > > >
> > > > > > You were right, the filter works fine. I don't know what I did
> wrong,
> > > > > > but I've already sent an email to JSPWiki's list to make it
> clear
> > > that
> > > > > > the problems I experienced were my fault.
> > > > > >
> > > > > > In the next days I'd like to give a try at the improvements
> mentioned
> > > > > > in my last email. Also I may try to fix some of the known
> issues you
> > > > > > added to the wiki. To that end it would be very helpful to have
> a
> > > > > > subversion repository against which I can create patches to
> send you
> > > > > > and then update when you commit them.
> > > > > >
> > > > > > Even if you decide not to use Sourceforge, Google code, etc,
> maybe
> > > > > > Janne could give you a dir in JSPWiki's repository?
> > > > > >
> > > > > > Regards,
> > > > > > Jorge
> > > > > >
> > > > > > On Feb 15, 2008 1:16 PM, Jorge Ferrer <[EMAIL PROTECTED]>
> wrote:
> > > > > > > Hi Christoph,
> > > > > > >
> > > > > > > Thanks for taking a look at it. I'm not using JSPWiki
> directly but
> > > > > > > through the integration that I've developed for Liferay
> Portal, I
> > > > > > > wonder if that has to do with my problems somehow. I'll do
> some
> > > > > > > debugging and will let you know.
> > > > > > >
> > > > > > > Also, have you planned to upload the project to Sourceforge,
> Google
> > > > > > > Code or some similar site? That would help to encourage
> people to
> > > > > > > contribute. I already have a couple of ideas to contribute:
> > > > > > > 1) Making it possible to insert pages using the Inclusion
> syntax
> > > > > > > defined in http://wikicreole.org/wiki/Inclusion This could be
> as
> > > > > > > simple as using the Insert JSPWiki plugin. The main challenge
> is
> > > how
> > > > > > > to differentiate between including pages and inlining images,
> since
> > > > > > > the Creole syntax is so similar
> > > > > > > 2) When including an image that does not exist yet, show a
> link
> > > that
> > > > > > > takes you to the add image attachment (like MediaWiki does).
> Not
> > > sure
> > > > > > > if this can be controlled at the CreoleFilter level.
> > > > > > >
> > > > > > > Thoughts?
> > > > > > >
> > > > > > > Regards,
> > > > > > > Jorge
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Feb 15, 2008 at 9:45 AM, Jorge Ferrer
> <[EMAIL PROTECTED]>
> > > > > wrote:
> > > > > > > > Hi Christoph,
> > > > > > > >
> > > > > > > > Thanks for your answer. I've attached the screenshot
> again. I
> > > guess
> > > > > > > > the JSPWiki mailing list dropped it.
> > > > > > > >
> > > > > > > > As you can see the rendering is just not done at all. And
> all I
> > > did
> > > > > > > > was put the creole filter WAR and the modify the
> filters.xml
> > > file
> > > > to
> > > > > > > > point to the new filter.
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > > Jorge
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Feb 15, 2008 at 7:08 AM, Christoph Sauer
> > > > > > <[EMAIL PROTECTED]> wrote:
> > > > > > > > > Hi Jorge,
> > > > > > > > > no, I will look into it over the weekend. You said
> something
> > > > about
> > > > > a
> > > > > > > > > screenshot, but there was none attached to the email.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > >I've downloaded and tried out this version, but it
> doesn't
> > > > > properly
> > > > > > > > > >convert links and headers. I've attached a screenshot
> which
> > > > shows
> > > > > > the
> > > > > > > > > >result of the Creole test case.
> > > > > > > > >
> > > > > > > > > Can you send me the screenshot again and tell me more
> about
> > > what
> > > > > > seems to be
> > > > > > > > > wrong with links and headers?
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --Christoph
> > > > > > > > >
> > > > > > > > > -----Ursprüngliche Nachricht-----
> > > > > > > > > Von: [EMAIL PROTECTED]
> > > > > > [mailto:[EMAIL PROTECTED] Im
> > > > > > > > > Auftrag von Jorge Ferrer
> > > > > > > > > Gesendet: Dienstag, 12. Februar 2008 17:34
> > > > > > > > > An: [EMAIL PROTECTED]
> > > > > > > > >
> > > > > > > > > Betreff: Re: What is the status of the development to
> support
> > > > > Creole?
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Hi Christoph,
> > > > > > > > >
> > > > > > > > > Did you have a chance to look at this problems? I'd
> like to
> > > > start
> > > > > > > > > using your version of the filter and probably try to
> > > contribute
> > > > an
> > > > > > > > > improvement to it. But when I tried using it it didn't
> work.
> > > Any
> > > > > > idea
> > > > > > > > > of what could be the reason?
> > > > > > > > >
> > > > > > > > > Regards,
> > > > > > > > > Jorge
> > > > > > > > >
> > > > > > > > > On Feb 4, 2008 7:22 PM, Jorge Ferrer
> <[EMAIL PROTECTED]>
> > > > wrote:
> > > > > > > > > > Hi Christoph,
> > > > > > > > > >
> > > > > > > > > > >I've uploaded a external implementation of the
> filter
> > > > (binaries
> > > > > > and
> > > > > > > > > > > sourceode at
> > > > > > > > >
> > > > http://www.i3g.hs-heilbronn.de/Wiki.jsp?page=JSPWikiCreoleFilter)
> > > > > > > > > >
> > > > > > > > > > I've downloaded and tried out this version, but it
> doesn't
> > > > > > properly
> > > > > > > > > > convert links and headers. I've attached a screenshot
> which
> > > > > shows
> > > > > > the
> > > > > > > > > > result of the Creole test case.
> > > > > > > > > >
> > > > > > > > > > > >What puzzles me is why is it looking for the
> plugin
> > > > > 'ImagePro'
> > > > > > if I
> > > > > > > > > > > >configured 'Image'. May that be related to the
> problem?
> > > > > > > > > > >
> > > > > > > > > > > I've added a debug var
> <<$creolepagefilter.imageplugin>>
> > > > that
> > > > > > let you
> > > > > > > > > find
> > > > > > > > > > > out what image plugin is used, if it displays
> "Image"
> > > > > everything
> > > > > > should
> > > > > > > > > be
> > > > > > > > > > > fine, "ImagePro" was just an experimental name like
> > > ImageX
> > > > to
> > > > > > see if it
> > > > > > > > > > > would work to switch Image display implementations.
> > > Please
> > > > > > install the
> > > > > > > > > new
> > > > > > > > > > > external filter and tell me if this displays
> something
> > > else
> > > > > than
> > > > > > you
> > > > > > > > > defined
> > > > > > > > > > >
> > > > > > > > > > > in your properties...
> > > > > > > > > >
> > > > > > > > > > I found out that the problem was actually in Creole's
> test
> > > > cases
> > > > > > as
> > > > > > > > > > they are using the following syntax to insert an
> image:
> > > > > > > > > >
> > > > > > > > > > [{ImagePro src='Red-Flower.jpg' caption='here is a
> red
> > > flower'
> > > > > }]
> > > > > > > > > >
> > > > > > > > > > Instead of what it should be:
> > > > > > > > > >
> > > > > > > > > > {{Red-Flower.jpg|here is a red flower}}
> > > > > > > > > >
> > > > > > > > > > Once I noticed this and changed to the correct syntax
> > > > everything
> > > > > > > > > > worked fine. I've also added a note in wikicreole.org
> > > letting
> > > > > them
> > > > > > > > > > know about this potential mistake.
> > > > > > > > > >
> > > > > > > > > > Thanks for your help,
> > > > > > > > > >
> > > > > > > > > > Jorge
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Jorge Ferrer
> > > > > > > > > > Software Architect
> > > > > > > > > > Liferay, Inc.
> > > > > > > > > > Enterprise. Open Source. For Life.
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Jorge Ferrer
> > > > > > > > > Software Architect
> > > > > > > > > Liferay, Inc.
> > > > > > > > > Enterprise. Open Source. For Life.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > >
> > > > > > > > Jorge Ferrer
> > > > > > > > Software Architect
> > > > > > > > Liferay, Inc.
> > > > > > > > Enterprise. Open Source. For Life.
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > Jorge Ferrer
> > > > > > > Software Architect
> > > > > > > Liferay, Inc.
> > > > > > > Enterprise. Open Source. For Life.
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Jorge Ferrer
> > > > > > Software Architect
> > > > > > Liferay, Inc.
> > > > > > Enterprise. Open Source. For Life.
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Jorge Ferrer
> > > > > Software Architect
> > > > > Liferay, Inc.
> > > > > Enterprise. Open Source. For Life.
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Jorge Ferrer
> > > > Software Architect
> > > > Liferay, Inc.
> > > > Enterprise. Open Source. For Life.
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Jorge Ferrer
> > > Software Architect
> > > Liferay, Inc.
> > > Enterprise. Open Source. For Life.
> > >
> > >
> > >
> >
> >
> >
> > --
> >
> >
> > Jorge Ferrer
> > Software Architect
> > Liferay, Inc.
> > Enterprise. Open Source. For Life.
> >
>
>
>
> --
> Jorge Ferrer
> Software Architect
> Liferay, Inc.
> Enterprise. Open Source. For Life.
>
>
>
--
Jorge Ferrer
Software Architect
Liferay, Inc.
Enterprise. Open Source. For Life.
