Dirk Frederickx wrote:
Janne,
This allows skins to change the image.
This has been a generic approach throughout the new template. (logo's,
other images, only the attachment icons still need to be handled)
Ensure presentation stuff is moved to css, so it can be changed
according the skins.
In the below code snippit, the should actually be changed by a
line-of-text, eg "RSS-feed", so things are still accessible when icons
are not loaded.
The downside of this is twofold.
a. if JavaScript if off, the images aren't seen. This is not simply
an aesthetic issue -- it may also affect branding and is considered
by many site managers a Pretty Big Deal.
b. absent the <img> elements there is no 'alt' text, so accessibility
suffers. E.g., I just realized that we have a *requirement* (set
by the government) to provide accessible websites, and that includes
alt text on *all* images. (yuck) We can probably skirt by on the
minor images, but certainly not logos and other important indicators.
and perhaps one more:
c. In some environments one may not want the images to be changeable
by the skins, only by the templates themselves.
I'm probably going to have to pull our current logo usage out of CSS and
put it into the XHTML. *sigh*
Murray
dirk
On Wed, May 14, 2008 at 8:44 PM, Janne Jalkanen (JIRA) <[EMAIL PROTECTED]>
wrote:
[
https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596891#action_12596891
]
Janne Jalkanen commented on JSPWIKI-208:
----------------------------------------
Dirk, why on earth is the image placed in CSS instead of direct content?
{code}
<a class="feed" ... > </a>
{code}
Hide RSS images if deactivated
------------------------------
Key: JSPWIKI-208
URL: https://issues.apache.org/jira/browse/JSPWIKI-208
Project: JSPWiki
Issue Type: Improvement
Components: Default template
Affects Versions: 2.6.0
Reporter: Cornelia Burko
Assignee: Janne Jalkanen
Priority: Minor
Fix For: 2.8
If the RSS feed is disabled in the jwpwiki.properties the image is still shown
beneath each article.
This one is not even marked by an specified css-class or id, so it could not
easily hidden via css.
The RSS image next to the jspwiki - version is hidden. It would be great if the
other images are hidden too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
--
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
