[ 
https://issues.apache.org/jira/browse/JSPWIKI-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623207#action_12623207
 ] 

Janne Jalkanen commented on JSPWIKI-348:
----------------------------------------

Not only is the patch against our guidelines, I just don't get what the problem 
is: there are lines which are commented out, and it adds a whole new class 
without explaining what the problem really is.  There are no comments in the 
patch either.

Unfortunately, until we understand the problem better, I don't think we can 
take this one in.  It looks brittle to me (in the sense that it might break on 
other containers).

> German umlauts not displayed properly on OC4J installation
> ----------------------------------------------------------
>
>                 Key: JSPWIKI-348
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-348
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.6.0, 2.6.1, 2.6.2, 2.6.3
>         Environment: openSuSe 10.3/Windows XP
> Oracle Container for J2EE (OC4J 10.1.3.1)
> JSPWiki 2.6.0/2.6.3
> Firefox 3/IE 6
>            Reporter: Lutz Tietze
>         Attachments: JSPWiki-348.patch
>
>
> The German umlauts are shown as chinese (?) letters. 
> The problem was found in the MyServletResponseWrapper in WikiJSPFilter.java. 
> The conversion of the outputstream into a CharArrayWriter seams to be 
> implemented differently on OC4J. The use of a ByteArrayOutputStream instead 
> works for OC4J. 
> Not tested on any other servlet container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to