Sorry :-/. I figured that since the JSPs were broken anyway, it didn't matter.

How about running the JspMigrator and just rewriting the JSPs to the new format right away? When code goes away from JSPs, most of these problems won't be problems anymore.

Another thing is that since JspMigrator is an one-off tool, perhaps it should be completely separated from the main jspwiki tree and developed into something more generic (and perhaps contributed back to Stripes?)

/Janne

On Dec 6, 2008, at 19:12 , Andrew Jaquith wrote:

All -- but mostly Janne:

The last checkin broke a lot of the JSPs because SearchResult, TextUtil, and FileUtil moved to sub-packages. I decided to add code to fix this problem in JspMigrator.

In general, JspMigrator proving to be pretty damn handy in fixing JSPs. I've already used it to automatically create stripes:useActionBean tags based on regex matches. It is still an evolving piece of code, but if you find it useful it is easy to extend via the JspTransformer interface.

(Of course, to do that it needs to accurately parse and model a JSP: not the easiest thing to do -- took me several weeks -- but I'm glad I did it...)

Andrew

Reply via email to