Done. However, there is a question on how we will do the subpage references, etc. The following sounds logical to me:

Assume in all that current WikiContext contains page "Foo:Bar/ Subpage", that is - that is the page which is being rendered.
Then:

"foo.jpg" => Check if "Foo:Bar/Subpage/foo.jpg" exists; if not, resolve to "Foo:Bar/foo.jpg" (This is consistent with current attachment references)
"/foo.jpg" => Always resolves to "Foo:Bar/Subpage/foo.jpg"
"../foo.jpg" => "Foo:foo.jpg"
"Test:Bar" => Is an FQN, therefore resolves to "Test:Bar"

I worry a bit about the "/pagename", since it kinda looks to me like a root reference (though there is no reason why it should be). But it is kinda logical - it refers to something "under this page".

/Janne

On Dec 9, 2008, at 04:59 , Andrew Jaquith wrote:

+1 for putting it in the trunk. I need it to do hierarchy-aware PagePermissions.

On Dec 8, 2008, at 18:03, Janne Jalkanen <[EMAIL PROTECTED]> wrote:

Folks,

I just checked in a new class called WikiName (in the *.content- package) into the JSPWIKI_JCR_BRANCH. The point of this class is to make it easier to support a multiwiki/subpage setup (so that we don't have to keep parsing/reparsing the paths in String format). It's a fairly straightforward thing to add transparent support to WikiPage as well.

Since it's not really that dependent on JCR itself, I'm wondering if it would make sense to check it into the trunk as well. Could you please check if it's a good or a bad idea, and whether it's ok to add to the trunk - and most importantly, would it make your life easier or harder? [I would imagine this would make Andrew's job easier at least.]

(Note, there is no factory yet, but one should probably be added.)


Reply via email to