3) Attempted to run AllTests, vaguely pissed that I had to hack a
properties file myself. Where does it tell a newbie that this is
needed, what is needed in it, etc. What a mess, they should just run.
Hacked at tests\etc\jspwiki.properties.tmpl (but I digress).
They *do* run. Did you run "ant tests" or "ant guitests"?
They form a dependency for the "tests-init" target, which builds all
the necessary property files for you.
After the tests-init target has been run, the tests should also run
from inside Eclipse.
4) Ran AllTests, Runs: 942/942 Errors:93 Failures:17
** Some of this is probably because my test environment isn't fully
configured?
** Maybe some of this is because I've got JDK6 on this box?
Certainly too many errors. Try running "ant tests".
is NOT the same!) ick ack ook. It *cleans* a link name, but doesn't
make any attempt to *normalize* it.
This is true - we do not have normalization. We do have a certain
mapping, though.
The thinking is that page names with spaces are the norm - and, if
the page does not exist, JSPWiki checks for "old style" pagenames
(pre 2.6).
My current thinking is that a little hack to the .cleanLink() will do
what I want. TextUtil.beautifyString could be employed
in .cleanLink to
make it commutative...
Probably not a good idea, since beautifyString() loses information.
Also, I don't think that our URI scheme is buggy as such. I would
like to see a proposal written out as to what it should do so that we
don't get any surprises (e.g. unreachable pages) - remember that 2.6
has been out for quite a while, so there are quite a few sites
already out there for whom we no longer can break the links.
PS: I would also like to "fix" the ugly %20 stuff in the URLs,
maybe via
a behavior property in DefaultUrlConstructor (or maybe just an
alternate
NormalizedShortViewUrlConstructor... For Christmas maybe?
Note that it cannot be fixed away, since there are already sites out
there who are using it. It may be mitigated, but we can't break the
URIs for other people...
/Janne
