[
https://issues.apache.org/jira/browse/JSPWIKI-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673511#action_12673511
]
Harry Metske commented on JSPWIKI-498:
--------------------------------------
Kurt,
a bit more room for improvement still:
* name your patch files properly, using the .patch suffix (makes handling
easier with most editors, and gives automatic correct syntax highlighting)
* some parameter names do not adhere to the standards
* method docs are incomplete
* please use the JSPWiki code formatting
(http://www.jspwiki.org/wiki/JSPWikiCodingStandard).
* an unnecessary import of StopWatch in Search.jsp
* there is still a findPages(String,int,int) left in WikiEngine
* is it possible to include one or more JUnit tests (to reduce the chance that
we break your work in the future) ?
Another suggestion: Have you tried using the Eclipse CheckStyle plugin ?
thanks,
Harry
> Performance Issues with Lucene Index
> ------------------------------------
>
> Key: JSPWIKI-498
> URL: https://issues.apache.org/jira/browse/JSPWIKI-498
> Project: JSPWiki
> Issue Type: Bug
> Components: Default template
> Affects Versions: 2.8.1
> Environment: Win 2003 on XEN-Server, 3 GB RAM, 4 x Intel Xeon 2Ghz
> Reporter: Kurt Stein
> Attachments: patch_lucene_search.txt, patch_lucene_search_2.txt,
> screenshot-1.jpg
>
>
> Our Wiki-Luceneindex has swollen to 33 MB and if someone searches words like
> "find" he gets about 500 results. Only problem is, it takes about 30 seconds
> to complete the search.
> I have looked a bit into the problem and there is something strange to me.
> JSPWiki searches twice every query.
> Once in search.jsp and afterwards in AjaxSearch.jsp.
> The filteredList from search.jsp is written to the pagecontext but this
> information is never read within the AjaxSearch.jsp. Thus AjaxSearch.jsp
> makes a second search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
