Janne Jalkanen wrote:
We might've made errors in declarations of the generics in the 2.8.x
branch; it certainly has not been reviewed very thoroughly.
We could document the ones which are critical; the 2.8.x is supposed to
be backwards compatible, so I'd rather not break compatiblity. Any
chance you could point out some of the errors we've made? Perhaps a
patch attached to a JIRA issue?
Hi Janne,
Well, I certainly make no claim as to the veracity of the generic
declarations in my own code, I've just had to go back through a copy
of 2.8.2 and added generic declarations where necessary to get my
own code (~200K lines) to compile without warnings or errors. I
could diff the resulting 2.8.2+ code against a fresh copy from svn
and provide that. Noting that my own code does not touch all of
JSPWiki's, only those portions I'm using (e.g., the basics plus the
plugin API and some of the core plugins).
One thing I'm running up on repeatedly is the mistakes made in the
JVM regarding Properties vs. Map<String,String>, and I'm wondering
if we might either consider writing a new Properties class that
wraps a Hashtable rather than extending it, or simply go back through
the code and replace all instances of Properties with
Hashtable<String,String>. That sounds radical and breaks compatibility,
but given that the Java5/6 Properties implementation is broken as
regards generics, this might not be so bad an idea. This is somewhat
a separate (but related) issue.
I can say at least one thing: this whole generics things has been
quite an education, or perhaps a re-education, for what that's worth.
I'm doing some expert witness work right now that's sucking up a lot
of my spare time but I'll be working on the generics issues for the
next week or so (I've worked down the warnings from about 4300 to
1300, so this has been a royal pain, enough that I'm looking into
Scala for my next project).
Murray
...........................................................................
Murray Altheim <murray09 at altheim dot com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
