Ok -- I think I am actually CONFUSED. The unit tests for MarkupParser show a test where the output of a cleaned-link is expected to have spaces.
So, which is it? Do we allow spaces in wiki page names? If so, that would suggest the failing JSPWikiMarkupParser test is wrong. Also, if spaces are allowed, how do you resolve page names? Are pages "Test Page" and "TestPage" the same page? Maybe I need to RTFM... just not sure where the M is... Andrew On Mon, Oct 12, 2009 at 7:26 PM, Andrew Jaquith <[email protected]> wrote: > This is fairly amusing... > > It turns out that one of the failing JSPWikiMarkupParser unit tests, > testHyperlinks3, is failing because MarkupParser.cleanLink() isn't cleaning. > > The link markup "hyperlink too" should result in "HyperlinkToo", no? It > results instead in "Hyperlink too". > > What's even more amusing is that MarkupParserTest doesn't even test for this > type of (common?) whitespace condition. Clearly we need to test for this -- > and I'll fix the bug too while I'm at it. :) > > Andrew >
