First, since 0.5.4 (which I have not checked in to the JSPWiki trunk),
there seems to be a big honking memory leak somewhere. The build is
stopping earlier than expected, right around the time
JSPWikiMarkupParser executes, because of an OutOfMemoryError. 0.5.3
does not have this problem -- it runs like a champ all the way
through.
I'll check this... I have a feeling it's related to the other bugs.
Second, WITH 0.5.4, PageRenamerTest.testAttachmentChange() is failing
because of this message:
javax.jcr.InvalidItemStateException: Looks like this Node has been
removed by another session: /pages/Main/RenamedTest
I'm currently working on moves (the SNS support is really hard to do
without screwing everything); I have something new on the hard drive
already which may be fixing this.
what SEEMS to be happening is that the item state of page node
RenamedTest is calling itself UPDATED, when perhaps it should say it
is MOVED? That is a guess.
No, that's ok. 0.5.x has a completely new way of storing the session-
specific changes, so getState() reflects the *latest* state. Which may
change if there are e.g. Nodes added or Properties changed.
Third, JSPWikiMarkupParser. testRenderingSpeed1() doesn't work under
0.5.3, probably for a reason having to do with the current build of
Priha.
Testcase: testRenderingSpeed1 took 0.336 sec
Caused an ERROR
Unable to add a page
org.apache.wiki.providers.ProviderException: Unable to add a page
at
org.apache.wiki.content.ContentManager.addPage(ContentManager.java:
1501)
at
org.apache.wiki.content.ContentManager.addPage(ContentManager.java:
1469)
at org.apache.wiki.WikiEngine.createPage(WikiEngine.java:1882)
at
org
.apache
.wiki
.parser
.JSPWikiMarkupParserTest.translate(JSPWikiMarkupParserTest.java:101)
at
org
.apache
.wiki
.parser
.JSPWikiMarkupParserTest
.testRenderingSpeed1(JSPWikiMarkupParserTest.java:2333)
Caused by: javax.jcr.RepositoryException: TURNED OFF FOR NOW
This suggests a serious bug in JSPWiki, which is creating a new page
*by the same name* as an existing page. Since JSPWiki currently is
using "nt:unstructured" as the page type, Priha will happily allow
these so-called same-name-siblings - as specified by JCR spec.
This functionality was turned off in 0.5.3, but it's enabled again in
trunk. However, in this case the test will pass but JSPWiki will not
work correctly.
I think we should either switch the node type, or add an assertion for
pages which already exist.
/Janne
