Interestingly, I applied your most recent checkins applied (and I have small one patch to JSPWikiMarkupParserTest that I haven't checked in). I am running 100% clean, with no errors. Total number of tests: 1024 -- a nice round number. :) WikiEngineTest.testOldVersionVars has been running fine for me for a while.
As a control case, I also checked out a new built from trunk, and simply typed 'ant tests'. I used a vanilla build with absolutely no customizations, even to build.properties. It ran completely clean also except for 1 JSPWikiMarkupParserTest test (because I haven't checked in that fix), 1024 tests total. The only other item causing the discrepancy would be if you don't have a local LDAP server running for the LDAP tests. Those should cause, at most, 14 failures or errors. I'll add in some code to build.xml to set up the LDAP fixtures and/or disable the tests if the OpenLDAP executable isn't available. Other than those caveats (which at the moment would cause max 15 errors/failures), like me, you should be clean. And I don't understand why you'd just see 990 tests... Hmm... Andrew On Mon, Oct 26, 2009 at 5:44 PM, Janne Jalkanen <[email protected]> wrote: > > I uploaded priha-0.5.6 which fixes these issues. However, I'm a bit > puzzled. > > I fixed WikiEngineTest.testOldVersionVars() which under *no* circumstances > should pass on your system - it was trying to load a configuration file > which does not exist in the SVN *at all*. So it may be that you're not > running all of the unit test cases. I have 990 tests that get run. > > Second, there were several cases still which did not call > WikiEngine.shutdown() correctly - in fact, it's not a good idea to use > assert() in setUp() or tearDown(), since if they fail, they will now cause a > massive cascade of failures down the stream. > > Second, I get 46 errors and 12 failures on the current test case set. > > JDBCGroupDatabaseTest, LdapAuthorizerTest, JDBCUserDatabaseTest, > LdapUserDatabaseTest, XMLUserDatabaseTest and HtmlStringToWikiTranslatorTest > fail with all tests; JSPWikiMarkupParserTest fails at > testHyperlinksExtNoFollow(). > > Didn't take a closer look at these now, but looks like there's still plenty > of work to do :-( > > (BTW, the tests take a very long time to run... Priha startup takes a couple > of seconds, so if we could figure out a way to avoid that, it would be > useful.) > > /Janne > > On Oct 26, 2009, at 20:13 , Andrew Jaquith wrote: > >> Hey Janne, >> >> I upgraded to Priha 0.5.5, PageRenamer.testBug25 and >> testAttachmentChange are the only unit tests that still fail (other >> than LDAP if an LDAP test server isn't running). >> >> Both are failing with messages similar to this... >> >> Could not rename page. Reason: Looks like this Node has been removed >> by another session: /pages/Main/RenamedTest >> >> org.apache.wiki.api.WikiException: Could not rename page. Reason: >> Looks like this Node has been removed by another session: >> /pages/Main/RenamedTest >> at >> org.apache.wiki.content.ContentManager.renamePage(ContentManager.java:1373) >> at org.apache.wiki.WikiEngine.renamePage(WikiEngine.java:2330) >> at >> org.apache.wiki.content.PageRenamerTest.testAttachmentChange(PageRenamerTest.java:237) >> Caused by: javax.jcr.InvalidItemStateException: Looks like this Node >> has been removed by another session: /pages/Main/RenamedTest >> at org.priha.core.SessionProvider.checkSanity(SessionProvider.java:621) >> at org.priha.core.SessionProvider.save(SessionProvider.java:345) >> at org.priha.core.SessionImpl.saveNodes(SessionImpl.java:499) >> at org.priha.core.SessionImpl.save(SessionImpl.java:484) >> at >> org.apache.wiki.content.ContentManager.renamePage(ContentManager.java:1369) >> >> I did a little digging, and what seems to happen is that >> ContentManager calls SessionImpl.move() successfully. But then the >> save() that immediately follows throws an error. Is there anything we >> can do inside JSPWiki to fix this? (Probably not... feels like Priha). >> >> Any chance you could take a peek at this? I suspect we are close to >> closing these. >> >> One more quick thing: the state of the build is stabilizing. The WAR >> builds fine, but runs a little funny because something is complaining >> about not finding certain JCR attributes when pages are displayed. >> This has been true since the upgrade from Priha 0.3x. I will hunt >> these issues down... >> >> Oh, and lastly, it'll be good to see you (and other local wikifolk) >> next week in Boston... >> >> Andrew > >
