[
https://issues.apache.org/jira/browse/JSPWIKI-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806687#action_12806687
]
Andrew Jaquith commented on JSPWIKI-578:
----------------------------------------
Checked in build 3.0.0-svn-201, which partially fixes this issue, mostly as a
proof-of-concept.
I implemented approach #2 -- eliminate the top-level JSPs and consolidate their
contents into the template JSPs. The physical files Wiki.jsp, Attachments.jsp,
PageInfo.jsp and Diff.jsp are now all gone, although the URLs will still
resolve like they used to, with one exception: /PageInfo.jsp. This is because I
kept the page-info event inside of ViewActionBean for the moment. If we still
want this URL binding, we can just subclass ViewActionBean or
AbstractPageActionBean and give it its own URL binding.
The template JSPs now contain ALL of the markup and whatever remaining
scriptlet code is needed. They are a *lot* simpler and nicer, too.
With this checkin, I took the opportunity to exploit JSTL more than we have
been doing. For instance, for displaying attachments, I iterated over the
ViewActionBean.getHistory() collection, rather than using the <HistoryIterator>
tag. This is actually pretty neat, and more efficient, because it doesn't
require WikiContext cloning -- JSTL just accesses the attachment objects
directly.
> Get rid of *.action URLs.
> -------------------------
>
> Key: JSPWIKI-578
> URL: https://issues.apache.org/jira/browse/JSPWIKI-578
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage, Default template
> Reporter: Janne Jalkanen
> Fix For: 3.0
>
>
> We currently have two URLs for each ActionBean - both the Wiki.jsp and
> Wiki.action are available. Now, since the URLs are different, it has some
> nasty side-effects:
> * Users don't know which URL to bookmark, or they end up bookmarking both
> pages
> * Browsers don't know which pages are equal, and therefore both caching and
> page highlights work inconsistently
> * Bots will index both pages, therefore giving odd results
> Since one of the design maxims of 3.0 is that URLs should not change, we
> should figure out a way to get rid of the Stripes-induced *.action URLs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
