Hi, 2.9.0-incubating-10 should run cleanly everytime, fixes the clean and hsqldb issues. Also, the libraries are downloaded from Central whenever is possible. Which leads me to a couple of questions:
1) what RC3 should be: as we haven't voted on it yet, I'd like that 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA, specially for Janne who is building and pushing the signed artifacts all along, so it would be ok for me if we vote on current RC3 tag / generated artifacts. 2) what to do with the jars placed at libs folder in svn: if we vote on current RC3 tag / artifacts, they should all remain there. If we vote on a tag based on 2.9.0-incubating-10, we could delete a big bunch of files. In any case, the jars remaining there after the release, should be there like, forever. As there are a few jars that aren't present on Central (i.e. jrcs, sandler and a few others), some jars are going to be in svn anyways. Also, there are some jars that could be downloaded from Central if we upgrade them to newer versions, but I think it's safer to do this later on, just to freeze the release.. thoughts? rgrds, juan pablo On Mon, Aug 6, 2012 at 12:54 AM, Juan Pablo Santos Rodríguez < [email protected]> wrote: > Hi, > > just added some comments there. Regarding the clean target + hsqldb > shutdown, I'll take a look at it this week [1], plus downloading the jars > from Central (whenever is possible), to avoid having a big libs folder in > our svn. No need to have this in the 3rd rc, but I'd like to have this > before graduating > > > br, > juan pablo > > [1]: the clean target should be a no-brainer, for hsqldb I was thinking of > pulling from build.xml into the appropiate setUp/tearDown methods, in order > to ensure it gets properly closed. > > > > On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <[email protected]>wrote: > >> Thanks Janne, >> >> true, I had already written down some notes on that before. There's >> pretty much to clean and simplify in our build process. But it's obviously >> been good enough until now, so that can wait till after graduation, I'd >> think. >> >> However, I'm wondering whether the library handling introduced in >> JSPWIKI-738 could lead to problems later on. I've added some notes in JIRA. >> >> Regards >> Florian >> >> >> ----- Ursprüngliche Mail ----- >> Von: "Janne Jalkanen" <[email protected]> >> An: [email protected] >> Gesendet: Sonntag, 5. August 2012 13:20:59 >> Betreff: Re: 3rd RC? >> >> >> Okay, got it building. Artifacts are now again at >> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/ >> >> The problem is that the ant scripts (nor ant clean) don't seem to do a >> proper cleanup. I don't check out a clean copy, I just svn switch my >> working copy around, and since ant clean doesn't really clean everything, >> old stuff is still out there. For example, hsqldb is not properly >> terminated at the end of run nor by ant clean. >> >> By running "svn status" and manually removing all the files that were >> autogenerated I can rebuild it without problem. >> >> /Janne >> >> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote: >> >> > Hi! >> > >> > done a fresh checkout from rc3 and could finish the ant clean signeddist >> > without problems >> > >> > >> > br, >> > juan pablo >> > >> > >> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen < >> [email protected]>wrote: >> > >> >> >> >> checked out the rc3, ant signeddist, no worky. >> >> >> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote: >> >> >> >>> Hi Janne, >> >>> >> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on >> >> Windows. Both are working fine. >> >>> >> >>> Name Status Type Time(s) >> >>> testIfPluginUserAllowed Success 0.946 >> >>> testIfPluginUserNotAllowed Success 0.126 >> >>> testIfPluginIPAllowed Success 0.083 >> >>> testIfPluginIPNotAllowed Success 0.115 >> >>> >> >>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737). >> Is >> >> v2.9.0-incubating-9 running in your test environment? >> >>> >> >>> Regards >> >>> Florian >> >>> >> >>> >> >>> ----- Ursprüngliche Mail ----- >> >>> Von: "Janne Jalkanen" <[email protected]> >> >>> An: [email protected] >> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11 >> >>> Betreff: Re: 3rd RC? >> >>> >> >>> >> >>> D'oh... I'd roll a new release but I've got failing unit tests >> >> (IfPluginTest). >> >>> >> >>> /Janne >> >>> >> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote: >> >>> >> >>>> Now that's funny: What should have avoided confusion obviously led to >> >> confusion :-) >> >>>> >> >>>> Janne, these are the old artifacts! >> >>>> >> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to >> >> tags/jspwiki_2_9_0_incubating_rc2. >> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3! >> >>>> >> >>>> Regards >> >>>> Florian >> >>>> >> >>>> >> >>>> ----- Ursprüngliche Mail ----- >> >>>> Von: "Janne Jalkanen" <[email protected]> >> >>>> An: [email protected] >> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02 >> >>>> Betreff: Re: 3rd RC? >> >>>> >> >>>> >> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/ >> >>>> >> >>>> /Janne >> >>>> >> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote: >> >>>> >> >>>>> Hi! >> >>>>> >> >>>>> I've just renamed rc2 to avoid confusion. >> >>>>> >> >>>>> 2.9.0 should be real near now :-) >> >>>>> >> >>>>> >> >>>>> br, >> >>>>> juan pablo >> >>>>> >> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek < >> >> [email protected]>wrote: >> >>>>> >> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3 >> >>>>>> >> >>>>>> Regards >> >>>>>> Florian >> >>>>>> >> >>>>>> >> >>>>>> ----- Ursprüngliche Mail ----- >> >>>>>> Von: "Janne Jalkanen" <[email protected]> >> >>>>>> An: [email protected] >> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20 >> >>>>>> Betreff: Re: 3rd RC? >> >>>>>> >> >>>>>> >> >>>>>> Just tag it and I'll build it from that tag :-) >> >>>>>> >> >>>>>> /Janne >> >>>>>> >> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote: >> >>>>>> >> >>>>>>> Hi all, >> >>>>>>> >> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC. >> >>>>>>> >> >>>>>>> Regards >> >>>>>>> Florian >> >>>>>>> >> >>>>>>> >> >>>>>>> ----- Ursprüngliche Mail ----- >> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <[email protected]> >> >>>>>>> An: [email protected] >> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03 >> >>>>>>> Betreff: 3rd RC? >> >>>>>>> >> >>>>>>> Hi, >> >>>>>>> >> >>>>>>> couple of days ago I was finally able to solve my problems >> regarding >> >> the >> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient >> >> windows-way: >> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was >> >> feeling >> >>>>>> now >> >>>>>>> would be a good moment to push a new RC, hoping that this time it >> >> will >> >>>>>>> become the first ASF release. Before doing that however, I was >> >> thinking >> >>>>>> of >> >>>>>>> pushing a coulpe of small changes: >> >>>>>>> >> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code, >> this >> >>>>>> could >> >>>>>>> imply upgrading other commons-* libraries, if they do depend on >> >>>>>>> commons-lang and don't know if that would cause to 3rd party >> >> plugins, if >> >>>>>>> they do depend on that library. Another possibility could be >> simply >> >>>>>> upgrade >> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most >> probably >> >> won't >> >>>>>>> break anything. >> >>>>>>> >> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines >> >> 505-530, to >> >>>>>>> retrieve and close Lucene indexes. Have that small change from >> days >> >> ago, >> >>>>>>> when I was pursuing ghosts; the functionally of the class remains >> >> exactly >> >>>>>>> the same, it's just a bit tinier. >> >>>>>>> >> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other >> thing >> >>>>>> before >> >>>>>>> making the next RC? >> >>>>>>> >> >>>>>>> >> >>>>>>> br, >> >>>>>>> juan pablo >> >>>>>>> >> >>>>>>> [#1] >> >>>>>>> >> >>>>>> >> >> >> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html >> >>>>>> >> >>>>>> >> >> >> >> >> >> >
