[
https://issues.apache.org/jira/browse/JSPWIKI-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495227#comment-13495227
]
Siegfried Goeschl commented on JSPWIKI-751:
-------------------------------------------
Reply from [email protected]
- first, the tests are actually running: guitests target depends on jar, which
in turn executes the tests target, before the tests are ran within the
junit.swingui.TestRunner. You should have the test report corresponding to the
first test execution at $SVN/tests/reports/junit-noframes.html, noting that 964
tests out of 964 ran OK.
- Strangely, junit.swingui.TestRunner runs only 962 tests, 17 of them failing.
There are some other weird issues with this runner:
+ lots of messages (a couple of thousands) on stdout like:
[java] log4j:ERROR [junit.runner.TestCaseClassLoader@776be68f] whereas
object of type
[java] log4j:ERROR A "org.apache.log4j.RollingFileAppender" object is
not assignable to a "org.apache.log4j.Appender" variable.
+ stacktraces regarding hsqldb startup (several dozens):
[java] [Server@5087c7a8]: [Thread[HSQLDB Server @5087c7a8,5,main]]:
run()/openServerSocket():
[java] java.net.SocketException: Unrecognized Windows Sockets error:
0: JVM_Bind
+ the tests target takes almost 5 minutes on my PC, whereas the guitests
takes half the time
+ the tests failing are all related to setup methods, failing because either
this code:
Context initCtx = new InitialContext();
throws an unexpected exception (no InitialContext available) or this one:
Properties props = new Properties();
props.put( PageSorter.PROP_PAGE_NAME_COMPARATOR,
HumanComparator.class.getPackage().getName() + ".HumanComparator" );
throws a NPE on the second line
+ Most importantly: all the(se) tests run fine through normal tests target /
Eclipse
- Wrapping up this issue, to me it seems an issue of junit.swingui.TestRunner,
which btw, is not present in JUnit 4.x (all modern IDEs support JUnit execution
from quite a while, so it seems like it didn't make sense to continue
mantaining this runner). So, I'd rather delete guitests target from build.xml,
as all the test are passing and the test failing issues seem to be related to
the runner, WDYT?
> The Ant target "guitests" fail with 17 out of 962 tests
> -------------------------------------------------------
>
> Key: JSPWIKI-751
> URL: https://issues.apache.org/jira/browse/JSPWIKI-751
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: Graduating
> Reporter: Siegfried Goeschl
> Fix For: 2.9.1
>
>
> During review of the project I also checked the "guitests" and they failed. I
> suggest fixing them after graduation instead having useless discussion along
> the lines "the tests are known to be broken", "the tests are not so
> important", you name it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
