that makes sense, I prefer "fails validation checks", it seems more accurate to me. Is it ok if I (or somebody else) commit the change in, i.e., a couple of hours??
On Mon, Jan 28, 2013 at 8:57 PM, Glen Mazza <[email protected]> wrote: > While we're fixing this, perhaps we should also change the "is illegal" > message we have for security.error.illegalfullname and > security.error.**illegalloginname > to "is invalid" or "fails validation checks". > > Glen > > > > On 01/28/2013 02:29 PM, Juan Pablo Santos Rodríguez wrote: > >> Hi, >> >> as part of JSPWIKI-143 and JSPWIKI-150, some i18n resources have been >> added/modified: >> >> CoreResources.properties - modified (lines 59-60): >> security.error.**illegalfullname=Full name ''{0}'' is illegal >> security.error.**illegalloginname=Login name ''{0}'' is illegal >> -> ("e; replaced by '' -two double-single quotes before and >> after >> {0}-, as "e; was being shown to the user) >> >> CoreResources.properties - added (lines 62-64): >> security.error.cannot.rename=**Cannot rename: the login name ''{0}'' >> is >> already taken. >> security.error.fullname.taken=**The full name ''{0}'' is already >> taken. >> security.error.login.taken=The login name ''{0}'' is already taken. >> >> default.properties (lines 457-458): >> notification.**createUserProfile.accept.**content=Congratulations\! >> Your new >> profile on {0} has been created. Your profile details are as follows\: >> \n\nLogin name\: {1} \nYour name \: {2} \nE-mail \: {3} \n\nIf you >> forget your password, you can reset it at {4} >> notification.**createUserProfile.accept.**subject=Welcome to {0} >> >> As they're minutes new, only the spanish files are updated, so L10N >> experts >> for the other languages, could you please update the other >> [CoreResources|default].**properties files too, or just reply it here? >> >> >> thxs and regards, >> juan pablo >> >> On Mon, Jan 28, 2013 at 8:16 PM, <[email protected]> wrote: >> >> Author: juanpablo >>> Date: Mon Jan 28 19:16:21 2013 >>> New Revision: 1439587 >>> >>> URL: >>> http://svn.apache.org/viewvc?**rev=1439587&view=rev<http://svn.apache.org/viewvc?rev=1439587&view=rev> >>> Log: >>> * 2.9.1-svn-22 >>> >>> * JSPWIKI-143: Unlocalized messages in user management >>> >>> * JSPWIKI-150: Unlocalized content at workflow's notification for >>> creating >>> a new user >>> >>> * Minor refactor to HsqlDbUtils init checks >>> >>> * deprecated >>> -> JSPWikiMarkupParser.**getImagePatterns( WikiEngine ) in favour of >>> WikiEngine.**getAllInlinedImagePatterns() >>> -> UserManager.**SaveUserProfileTask( WikiEngine ) in favour of >>> UserManager.**SaveUserProfileTask( WikiEngine, Locale ) >>> >>> Modified: >>> incubator/jspwiki/trunk/**ChangeLog >>> incubator/jspwiki/trunk/src/**org/apache/wiki/Release.java >>> >>> Modified: incubator/jspwiki/trunk/**ChangeLog >>> URL: >>> http://svn.apache.org/viewvc/**incubator/jspwiki/trunk/** >>> ChangeLog?rev=1439587&r1=**1439586&r2=1439587&view=diff<http://svn.apache.org/viewvc/incubator/jspwiki/trunk/ChangeLog?rev=1439587&r1=1439586&r2=1439587&view=diff> >>> >>> ==============================**==============================** >>> ================== >>> --- incubator/jspwiki/trunk/**ChangeLog (original) >>> +++ incubator/jspwiki/trunk/**ChangeLog Mon Jan 28 19:16:21 2013 >>> @@ -1,3 +1,19 @@ >>> +2013-01-28 Juan Pablo Santos (juanpablo AT apache DOT org) >>> + >>> + * 2.9.1-svn-22 >>> + >>> + * JSPWIKI-143: Unlocalized messages in user management >>> + >>> + * JSPWIKI-150: Unlocalized content at workflow's notification for >>> creating a new user >>> + >>> + * Minor refactor to HsqlDbUtils init checks >>> + >>> + * deprecated >>> + -> JSPWikiMarkupParser.**getImagePatterns( WikiEngine ) in >>> favour >>> of >>> + WikiEngine.**getAllInlinedImagePatterns() >>> + -> UserManager.**SaveUserProfileTask( WikiEngine ) in favour >>> of >>> + UserManager.**SaveUserProfileTask( WikiEngine, Locale ) >>> + >>> 2013-01-27 Dirk Frederickx (brushed AT apache DOT org) >>> >>> * 2.9.1-svn-21 >>> @@ -56,12 +72,12 @@ >>> >>> * 2.9.1-svn-16 >>> >>> - * some additional changes regarding >>> org.apache.wiki.api.engine.**PluginManager (cfr. >>> $SVN/trunk/doc/2.10-API.txt): >>> + * some additional changes regarding >>> org.apache.wiki.api.engine.**PluginManager (cfr. >>> $SVN/trunk/doc/2.10-API.txt): >>> -> @Deprecated public void executeParse(PluginContent content, >>> WikiContext context) >>> + consider using PluginContent.executeParse(** >>> WikiContext) >>> instead >>> -> WikiPlugin newWikiPlugin( String pluginName, ResourceBundle >>> rb ) is now public and part >>> of the org.apache.wiki.api.engine.**PluginManager API >>> - >>> + >>> 2013-01-09 Juan Pablo Santos (juanpablo AT apache DOT org) >>> >>> * 2.9.1-svn-15 >>> >>> Modified: incubator/jspwiki/trunk/src/**org/apache/wiki/Release.java >>> URL: >>> http://svn.apache.org/viewvc/**incubator/jspwiki/trunk/src/** >>> org/apache/wiki/Release.java?**rev=1439587&r1=1439586&r2=** >>> 1439587&view=diff<http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/org/apache/wiki/Release.java?rev=1439587&r1=1439586&r2=1439587&view=diff> >>> >>> ==============================**==============================** >>> ================== >>> --- incubator/jspwiki/trunk/src/**org/apache/wiki/Release.java >>> (original) >>> +++ incubator/jspwiki/trunk/src/**org/apache/wiki/Release.java Mon Jan >>> 28 >>> 19:16:21 2013 >>> @@ -75,7 +75,7 @@ public final class Release >>> * <p> >>> * If the build identifier is empty, it is not added. >>> */ >>> - public static final String BUILD = "21"; >>> + public static final String BUILD = "22"; >>> >>> /** >>> * This is the generic version string you should use >>> >>> >>> >>> >
