Re: Possible change to avoid a Tomcat shutdown "hang" -- make subscription timer thread be "daemon"

[Kurt T Stam]

I noticed that too, thx for the patch!

https://issues.apache.org/jira/browse/JUDDI-308

Cheers,

--Kurt

Bryan Pendleton wrote:

In my environment, working with the 3.0.0 Tomcat and/or Portal bundles,
I observe the following behavior:

 - I double-click startup.bat to start Tomcat
 - I wait til it's up and running and says "Server startup in NNN ms"
 - I double-click shutdown.bat to stop Tomcat

I see messages in the Tomcat console indicating that Tomcat is
shutting down, but the shutdown never completes.

When I did "Control-Break" in the Tomcat console, I see that there
is a Timer thread which is NOT marked as a daemon thread, which is
I think what is preventing the shutdown.

I applied the following patch in my environment, and now Tomcat shuts
down cleanly with the shutdown.bat.

What do you think? Is this a reasonable change?

thanks,

bryan

Index: src/main/java/org/apache/juddi/subscription/SubscriptionNotifier.java

===================================================================

--- src/main/java/org/apache/juddi/subscription/SubscriptionNotifier.java (revision 834136) +++ src/main/java/org/apache/juddi/subscription/SubscriptionNotifier.java (working copy)

@@ -69,7 +69,7 @@

        public SubscriptionNotifier() throws ConfigurationException {
                super();
-               timer = new Timer();
+               timer = new Timer(true);
                timer.scheduleAtFixedRate(this, startBuffer, interval);
        }