On 10/22/2012 8:28 PM, john skaller wrote:
> On 23/10/2012, at 11:27 AM, Doug Baskins wrote:
>> P.S.  It has been suggested that the  4 JudyxTables.c files be delivered, 
>> rather than constructed.
>> I give them the names: JudyLTables32.c, JudyLTables64.c, Judy1Tables32.c and 
>> Judy1Tables64.c
>> in the new Judy.  But I still use the JudyTables.c tool to construct them.
Great! That does seem simpler, and would allow someone to include them 
in a project without the extra step of constructing them themselves.  
(If you're using a command-line compiler, it doesn't make any practical 
difference, but delivering the files does seem more straightforward.)

> This is a good idea.  I would also suggest that those JudyL/Judy1 codes
> generated by the same file with command line macros be replaced
> by *.include file and two C files which include them with the macros
> set in those files. It should be possible to build Judy by simply compiling
> all the *.c files in the library directory and linking them to a DLL or
> making a static link library.
I agree that that would be valuable.  John and I had talked about that 
in private email.  I was going to bring it up when I finished my other 
tweaks.  (Which I'm testing now, by the way.  It was simpler than I 
thought.)

So for example, JudyFirst.c (which is currently copied-and-renamed 
during building to "JudyLFIrst.c" and "Judy1First.c", then compiled with 
"-DJUDYL" and "-DJUDY1" respectively) would be delivered as the two files:

        //Judy1First.c
        #define JUDY1
        #include JudyFirst.include

        //JudyLFirst.c
        #define JUDYL
        #include JudyFirst.include

I imagine the same thing would be done with the other -D macros being 
used with a few of the files.

Again, if you're using a command-line compiler with a delivered batch 
file then there's no difference, but it would make the 
files-as-delivered a bit easier to use with an alternate build system.  
I like very much the idea of making the build process into "compile all 
the delivered *.c files and link them".

If you like that change and want to integrate it, I'm willing to do the 
renaming on my system and submit it along with my other tweaks. (I can 
also edit sh_build, but not test it.)  What do you think about packaging 
up those changes along with the table-generation change, and making them 
Judy 1.0.6?


---
Tim Margheim
Neuric Technologies, LLC

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Judy-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/judy-devel

Reply via email to