On Tue, Jun 17, 2014 at 12:39 AM, Andrew Wilkins < andrew.wilk...@canonical.com> wrote:
> Hi all, > > I've started looking into fixing > https://bugs.launchpad.net/juju-core/+bug/1215579. The gist is, we > currently set private-address in relation settings when a unit joins, but > never update it. > > I've had some preliminary discussions with John, William and Dimiter, and > came up with the following proposal: > https://docs.google.com/a/canonical.com/document/d/1jCNvS7sSMZqtSnup9rDo3b2Wwgs57NimqMorXr9Ir-o/edit > > If you're a charm author, particularly if you work on "proxy charms", > please take a look at this and let me know of any concerns or suggestions. > I have opened up comments on the doc. > > In a nutshell: > - There will be a new hook, relation-address-changed, and a new tool > called address-get. > This seems less than ideal, we already have standards ways of getting this data and being notified of its change. introducing non-orthogonal ways of doing the same lacks value afaics or at least any rationale in the document. the two perspectives of addresses for self vs related also seem to be a bit muddled. a relation hook is called in notification of a remote unit change, but now we're introducing one that behaves in the opposite manner of every other, and we're calling it redundantly for every relation instead of once for the unit? > - The hook will be called when the relation's address has changed, and > the tool can be called to obtain the address. If the hook is not > implemented, the private-address setting will be updated. Otherwise it is > down to you to decide how you want to react to address changs (e.g. for > proxy charms, probably just don't do anything.) > perhaps there is a misunderstanding of proxies, but things that set their own address have taken responsibility for it. ie juju only updates private address if it provided it, else its the charms responsibility. fwiw, i think this could use some additional discussion.
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
