I made this pull request: https://github.com/juju/juju/pull/495
It adds a test to run godeps in the root juju directory and ensures that the output matches dependencies.tsv. This will ensure there's a failing test if you're trying to run the tests and haven't run godeps -u to make your environment match the branch's dependencies. It also will fail if you have added a new import to the project, but haven't updated dependencies.tsv. This does add an explicit requirement that you have godeps to run the tests... but since we already require godeps to set up the environment correctly, I don't think that's actually a problem. The only thing that I think could be controversial is that it assumes godeps is in your $PATH, which for some masochistic people, may not be true. I'm fine with making this call $GOPATH/bin/godeps instead (the default directory where godeps will be put when you run go install launchpad.net/godeps). Not sure which one people will find less offensive :) I think this is an important test to add, to make sure the dependencies.tsv doesn't get out of sync with reality (which is what caused one of the CI blocking bugs recently). Now that npipe can be imported as a dependency on all OSes, godeps -t ./... can be relied upon to produce the correct output. -Nate
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
