I wasn't able to work out why my test failed on windows, but I was able to realise that it wasn't really testing what I wanted. I'm landing a further change now that makes the tests a little better, and adds a new one, and I've confirmed that they pass in the right way on windows and ubuntu.
Matty On Fri, Apr 24, 2015 at 11:43 AM, John Meinel <j...@arbash-meinel.com> wrote: > That's really great! > > John > =:-> > > > On Fri, Apr 24, 2015 at 1:59 PM, Gabriel Samfira < > gsamf...@cloudbasesolutions.com> wrote: > >> That is great news! Congrats guys! :) >> >> >> Cheers, >> Gabriel >> ________________________________________ >> From: juju-dev-boun...@lists.ubuntu.com [ >> juju-dev-boun...@lists.ubuntu.com] on behalf of Martin Packman [ >> martin.pack...@canonical.com] >> Sent: Friday, April 24, 2015 12:56 PM >> To: juju-dev@lists.ubuntu.com >> Subject: Re: Test suite on windows now voting on trunk >> >> On 23/04/2015, Martin Packman <martin.pack...@canonical.com> wrote: >> > Well, mostly good news after Matty and I landed workarounds. There's a >> > single remaining failure that has manifested since: >> > >> > TestLeadership fails on windows test slave >> > <https://bugs.launchpad.net/juju-core/+bug/1447595> >> >> With Bogdan's fix landed, we've had our first clean run on CI: >> >> < >> http://reports.vapour.ws/releases/2558/job/run-unit-tests-win2012-amd64/attempt/287 >> > >> >> Description set: Revision build: 2558 >> gitbranch:master:github.com/juju/juju 73cde95d >> Finished: SUCCESS >> >> Thanks for helping out everyone! >> >> Martin >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> > > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > >
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev