Just as a follow up, I went ahead and merged the OpenBook MP, as it LGTM aside from a few nits that really aren't blockers. Thanks for the attention to detail.
All the best, Charles Butler <charles.but...@canonical.com> - Juju Charmer Come see the future of modeling your datacenter: http://jujucharms.com On Mon, Jan 25, 2016 at 9:20 AM, Cory Johns <cory.jo...@canonical.com> wrote: > Greetings, > > This past Friday, Andrew, Konstantinos, and I spent some time on the > review queue. > > We'd like to thank the fine folks at MetaSwitch for their work on the bird > and neutron-calico charms, which add Project Calico and its virtual > networking support to OpenStack. > > > - > > bird > - > > https://bugs.launchpad.net/charms/+bug/1431445 > - > > Suggested changes were accepted. Re-tested, passed, and the charm > was promulgated. > - > > neutron-calico > - > > https://bugs.launchpad.net/charms/+bug/1421230 > - > > Suggested changes were accepted. Re-tested, passed, and the charm > was promulgated. > - > > openbook > - > > > > https://code.launchpad.net/~talligent/charms/trusty/openbook/trunk/+merge/280525 > - > > Tests all pass - this was held back due to long dashes in the > README and non-recommended tags in the metadata, neither of which will > affect charm functionality. Suggesting this be merged as the value of > the > charm outweighs potential README issues. > - > > plumgrid-gateway > - > > > > https://code.launchpad.net/~bbaqar/charms/trusty/plumgrid-gateway/charmers-next > - > > Reviewing the fix for restarting the service in a timely fashion > yields some more questions. > - > > The bundletester spotted some code style errors. > - > > We will have to wait for a response from the author, before we > proceed with this merge. > > > -- > Juju mailing list > Juju@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju > >
-- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
