Hey Juju,
Andrew, Kostas, Cory, and I made our way through a slew of reviews. It
went something like this:
-
minecraft
-
https://bugs.launchpad.net/charms/+bug/1523896
-
This is a rewrite of the precise minecraft charm, now using layers
and targeting trusty.
-
We found a problem with the author’s ./trunk branch (possibly due to
bzr artifacts between ‘charm build’ attempts), and suggested some test
changes via a PR. The author addressed both of these issues and
all looks
good.
-
+1, promulgated, https://jujucharms.com/minecraft/trusty is live!
-
rsyslog-forwarder-ha
-
https://code.launchpad.net/~johnsca/charms/trusty/rsyslog-forwarder-ha/lint/+merge/288469
-
Fixes lint issues
-
Previously, ‘make test’ would pollute the system with a version of
PyYAML that was incompatible with ‘charm proof’. The author has
fixed this
with tox.
-
+1, merged
-
zulu8
-
https://bugs.launchpad.net/charms/+bug/1519858
-
This is a layered bash charm that implements the java interface to
provide a Zulu java environment.
-
Testing was successful, and while we created an MP for minor tweaks
(e.g. decreasing log noise), this didn’t warrant holding it up
for further
review.
-
+1, this is the first promulgated charm leveraging the java interface
layer!
-
rlec (new redis charm)
-
https://bugs.launchpad.net/charms/+bug/1551133
-
Missing crypto hash verification of the download
-
Issues with handling of leadership and node registration
-
Some erroneous boilerplate from `charm create` template
-
We also offered relation suggestions
-
-1 for now while the author considers these points
-
haproxy (new statistics interface)
-
https://code.launchpad.net/~verterok/charms/trusty/haproxy/statistics-interface/+merge/288005
-
Bundletester (still) works fine, make build with new test works too.
However, I manually deployed and related to telegraf and couldn’t see any
hooks fired related to statistics so have asked the author for
instructions
to test further…
-
Author replied almost immediately and suggested I test against a
different telegraf MR - it did and it worked, so +1 for merging.
-
Apache2 (timeouts fix)
-
https://code.launchpad.net/~kwmonroe/charms/trusty/apache2/timeouts/+merge/287222
-
Adding some slack in the unit deployment timeout.
-
Tests pass.
-
+1 for merging
-
Apache2 (ensure_package_status fix)
-
https://code.launchpad.net/~lutostag/charms/trusty/apache2/fix-extra-package-hold/+merge/287224
-
This fix is for a check on extra package installations that was
producing a warning.
-
We reviewed the code and run a couple of tests.
-
+1, merged
-
fiche (new charm)
-
https://bugs.launchpad.net/charms/+bug/1530976
-
The author addressed our comments. However we asked for the layer
that is used to build the charm.
-
Adam Israel jumped in to finish the review and promulgate (thanks
Adam!)
-
midonet-gateway (new charm)
-
https://bugs.launchpad.net/charms/+bug/1541735
-
Review items addressed
-
Unable to run tests, but James offered to do so and give final sign
off.
-
Otherwise, looks good from review. +1
-
collectd (new charm)
-
https://bugs.launchpad.net/charms/+bug/1538573 and layer at
https://code.launchpad.net/~jacekn/canonical-is-charms/collectd-composer
-
This is the third iteration over the collectd charm, and we
appreciate the author’s dedication to addressing our comments!
-
Unfortunately, we spotted a small typo in the templating section that
needs to be fixed. We also had some suggestions to improve the
README. We
submitted an MP to address both of these issues.
- We’ll wait for the author’s input on our MP, but feel this is very
close to promulgation.
Thanks for all the submissions - we found lots of great new additions
during this review. Questions or comments? Let us know in #juju on
freenode. If we're not playing minecraft, we'll be right with you :)
Thanks,
-Kevin Monroe
--
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju
