Thanks Cory and team!
I didn't test my Charm on a public cloud, which meant I had a code path that wasn't executed before. I fixed it and used my Charm Developer Program Credentials® verify on AWS. Mentioning it because those are very useful! :) I uploaded the next version to the Charm Store; do I need to do anything else to get a re-review? Regards M 2017-02-03 16:56 GMT+01:00 Cory Johns <cory.jo...@canonical.com>: > Greetings! > > Kevin, Konstantinos, Pete, and I worked on the queue yesterday. Got a new > promulgation, and some feedback. Thanks to the charming community! > > Feb 2, 2017: Cory, Kevin, Kostas, Pete > > - > > Websphere Liberty > - > > https://review.jujucharms.com/reviews/48 > - > > Deployment looks good; tests pass. > - > > +1, promulgated: > - > > https://jujucharms.com/websphere-liberty/ > - > > Canonical-Livepatch > - > > https://review.jujucharms.com/reviews/46 > - > > Good, modulo linter errors. > - > > ganglia-node > - > > https://review.jujucharms.com/reviews/51 > - > > The test.yaml appears to be missing a python-packages declaration, > which means that the amulet tests are missing required python packages. > - > > gluster > - > > https://review.jujucharms.com/reviews/43 > - > > There were a couple of issues we found during review. > - > > No tests > - > > Readme needs updates > - > > We will have to wait for the author’s input for this. > - > > openvpn > - > > https://review.jujucharms.com/reviews/58 > - > > Charm itself looks great, but has install hook and test timeout > failures > > > > -- > Juju mailing list > Juju@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/ > mailman/listinfo/juju > >
-- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
