Hi Elliot, Just to clarify, the KyotoCabinet license is actually GPLv3, with the option to purchase a separate commercial license. (One has to download the source to actually see the license.) But I agree that it's a good idea to clarify the license situation.
Cheers, Kevin On Sat, Aug 30, 2014 at 8:28 AM, Elliot Saba <staticfl...@gmail.com> wrote: > Cool! I've used KyotoCabinet before, so it's nice to see this coming in > to Julia! Your code looks really nice, the only thing I can think of to > add is perhaps a notice to LICENSE.md that while your code is MIT-licensed, > KyotoCabinet is not. It's free for personal use, but commercial use > requires a commercial license <http://fallabs.com/license/>. > > One other thing worth mentioning is that because you have *@osx Homebrew* in > your REQUIRES file, you don't need to check for *if > Pkg.installed("Homebrew") *in your deps/build.jl file. You can just > delete that if statement, we never need to have those ever again, now that > we have conditional requirements in Pkg. > -E > > > On Sat, Aug 30, 2014 at 1:00 AM, Dmitry Semyonov <deemons...@gmail.com> > wrote: > >> Hi all, >> >> I used KyotoCabinet <http://fallabs.com/kyotocabinet/> key-value storage >> in some of my Python projects, but couldn't find bindings for Julia. So I >> wrote something by myself. Hope it might be useful for someone else. >> >> Here is the source: https://github.com/tuzzeg/kyotocabinet.jl >> >> I am pretty new in Julia world, so if you have comments, code >> style/performance/design suggestions - I'd love to hear them. >> >> Cheers, >> Dmitry >> > >
