Following up, the easiest way I've found to fix things so they're 
cross-version is to change my test from

foo = [1 2 3 4 5]
@test [1, :] == [1 2 3 4 5]

to 

foo = [1 2 3 4 5]
@test [1, :][:] == [1, 2, 3, 4, 5]   # note the trailing [:]


This works on both 0.4 and 0.5.


On Wednesday, November 11, 2015 at 9:31:28 PM UTC-8, Tony Kelman wrote:
>
> We could possibly start adding feature flags for this kind of change 
> that's only in semantics and not syntax. Maybe better to put that kind of 
> flag in Compat.jl by way of a dummy indexing test rather than in Base?
>
>
> On Wednesday, November 11, 2015 at 8:50:17 PM UTC-8, Seth wrote:
>>
>> Thanks, Tony. It's in tests, so I guess I can make it version-dependent. 
>> Is there a better way to do it? I had version conditionals throughout the 
>> code during the 0.3 - 0.4 cycle, and it was less than ideal. I'd like to 
>> avoid that again if at all possible.
>>
>>
>> On Wednesday, November 11, 2015 at 8:43:02 PM UTC-8, Tony Kelman wrote:
>>>
>>> Yes. https://github.com/JuliaLang/julia/pull/13612
>>> It's in NEWS.md.
>>>
>>> Make your code version-dependent if it can't handle the new behavior.
>>>
>>>
>>> On Wednesday, November 11, 2015 at 8:19:32 PM UTC-8, Seth wrote:
>>>>
>>>> LightGraphs started failing 0.5 tests, while -release is fine:
>>>>
>>>> https://travis-ci.org/JuliaGraphs/LightGraphs.jl/jobs/90631116
>>>>
>>>> apparently foo[3,:] now returns [x,y,z] instead of [x y z].
>>>>
>>>> 1) could someone confirm this new behavior?
>>>> 2) what's the best way of handling this besides disabling tests on 0.5?
>>>>
>>>>

Reply via email to