IMHO, It would also make sense to extend `diagm` to (n x 1 x 1), (n x 1 x 1 
x 1), (1 x n x 1) ... arrays. 

But, if we check the dimension in the function body, it may decrease the 
performance (IMHO).

Note that you can always write `diagm(vec(a))` to transform it to a vector.




On Friday, April 8, 2016 at 6:59:37 AM UTC+2, SrAceves wrote:
>
> Wouldn't it make sense to extend diagm to accept (n x 1) Array{T, 2}?
>

Reply via email to