Yes, PRs to the main repo are welcome. It would be great if you could write up a short issue describing how this code goes about things. There are quite a number of strategies on how to achieve things in VS code (language server protocol vs everything in typescript vs mixed language solutions) and it would be good to sort out what is the right strategy for the extension, and how this new code fits in there.
From: julia-users@googlegroups.com [mailto:julia-users@googlegroups.com] On Behalf Of Zac Sent: Friday, October 28, 2016 8:40 AM To: julia-users <julia-users@googlegroups.com> Subject: [julia-users] Re: VS code extension Ok then, https://github.com/ZacLN/julia-vscode . I'll look into trying to make a pull request on the main repo. On Friday, October 28, 2016 at 3:29:17 PM UTC, Tony Kelman wrote: The repo's MIT licensed, so unless this person changed the license of their additions, yes. Best to preserve git authorship attribution if you can. Pull requests to the JuliaEditorSupport repository are encouraged, I imagine. On Friday, October 28, 2016 at 3:31:56 AM UTC-7, Zac wrote: Hi, I'm using a fork of this that implements completions, function parameter hints, documentation hovers, linting and definitions. I pulled it from another fork that has subsequently disappeared (github.com/novatena <http://github.com/novatena> ). This Given that someone else did most of the work is it ok to share it here? On Tuesday, July 5, 2016 at 4:33:06 PM UTC, FANG Colin wrote: Thank you. I used to use https://github.com/Mike43110/julia.vscode which unfortunately doesn't provide the command for mark selection as comments.
