Michael, do you keep in mind to update the readme.txt accordingly if you modify PLUS?
thanks.. ede On 11.08.2012 22:18, Michaël Michaud wrote: > Hi Stefan, > > I made small changes to the csv driver and uploaded the sources in the > plugin repository > > - now auto mode import empty GeometryCollection if no geometry column is > detected > - options mode import empty GeometryCollection if x column or y column > are set to '-' > (dash character, after the sixteenth column) > > - I did not do anything for data type detection. Feel free to patch. > > - the jar file is in the dist directory (csv-driver-0.6.5.jar). > I'll put it in the ext directory for OJ PLUS version after you have > given it a try > > Michaël > >> Hi Michael, >> >>> I suggest to add the feature you ask in the automatic mode : >>> no geometry found -> create empty GeometryCollection >> ok, sounds good, but that should be documented somewhere. >> However, I used the manual settings option, just to get sure. So having >> it there maybe helpful too. >> >>> What do you mean ? I can save a layer with no feature in JML and I can >>> save a layer >>> with a single GEOMETRYCOLLECTION EMPTY. >> I created null geometry points for the csv with no geometry info using: >> >> Coordinate cord = null; >> Geometry defaultGeometry = new GeometryFactory().createPoint(cord); >> >> maybe that was the mistake. I will change it to empty >> GeometryCollection. Thanks for the hint! >> >>> Did you try to save a feature with a null geometry ? How did you create it ? >>> I don't think we should authorize it. >> mhm.. not sure? >> May point is that I think it would be a good idea to allow handling of >> non geometry datasets (= tables) and saving them to JML? but the empty >> GeomentryCollection would solve that (more or less). >> just a thought >> >>> Yes, it is a possible improvement. There are some reasons why it is not >>> already done : >> yes.. I see the reasons too. >> Actually, I am not sure if the type casting is a good way too... need to >> check what happens in the case that a column has no entries in some >> places but "0" can be there too. I.e. avoid the conversion "null" => 0. >> >> ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Jump-pilot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
