1. open Project Properties
2. enable Metadata Change checkbox (a "Cancel" button that is enabled
together with "Apply")
3. change the comment
4. ups, i erred, i want the old entry back
As the GUI is defined (by MultiInputDialog) can see two schenarios:
*) If the "Apply" button is not clicked, it close the diallog with no
effects on any modification the user can do (see Style dialog). *The old
good entry is save*.
but
**) if the "Apply" button is clicked before than "Cancel" button, this
will close dialog but modifications are not restored to original values. *The
old good entry is gone.*
I am thinking more to an extra button, located close to "Edit project
metadata", called "Restore metadata form file" that does the job.
This would work even if the user changes his mind after having clicked
"Apply" and inadvertently closed the dialog.
Extra schenario. The user does 1 to 4 steps, click "Apply" button, closes
the dialog, *saves project* and "repents at the end of his days".
Possible solutions
a) add an extra warning on SaveProject plugin that that project is going to
be saved
b) implement undo/redo on TaskPropertiesPlugin
Peppe
2017-05-22 11:56 GMT+02:00 <edgar.sol...@web.de>:
> Peppe,
>
> not to be misunderstood. consider this flow
>
> 1. open Project Properties
> 2. enable Metadata Change checkbox
> 3. change the comment
> 4. ups, i erred, i want the old entry back
>
> now the user has a UI that only allows
> hit APPLY and then OK (values are saved, user does not want that!)
> or
> disable the Metadata checkbox, hit OK (the value is not saved, but it
> looks as if because it is still there until the dialog is reopened)
> or
> close the dialog via the X of the frame
> .
>
> a "proper" UI would actually compare the values (saved vs. dialog) and
> only if they differ show Cancel/Apply buttons instead of OK. Apply would
> update the task properties, Cancel restore the dialog fields with the old
> values. Result of both would be no difference between saved vs. dialog
> values anymore, hence OK is shown.
>
> something like that.. ede
>
>
> On 22.05.2017 11:24, Giuseppe Aruta wrote:
> > Thanks for the enhancement on OK/Apply buttons, Ede.
> > I did a small upgrade of the GUI: it showns the unit as a separate box,
> in
> > case one day we improve unit conversion.
> > I prefer to have a dedicate button (like "Restore properties from the
> > file") instead to have a cancel button. I added a method on Utils class.
> Or
> > we can have both. but this makes thinks more ambiguous for users (my
> > opinion). And we want to have OJ as more easy as possible
> > Peppe
> >
> > 2017-05-21 13:39 GMT+02:00 <edgar.sol...@web.de>:
> >
> >> Peppe,
> >>
> >> one issue still remains though. if there is an APPLY button, there
> should
> >> be a CANCEL button to abort _and_ restore the previous state. i leave
> that
> >> to you in case you are interested. the needed method's to hide,
> en/disable
> >> are in place now.
> >>
> >> it's sunday, so i am being lazy.. ede
> >>
> >> On 21.05.2017 13:01, edgar.sol...@web.de wrote:
> >>> ok, checked your code :).. ProjectInfoPlugIn.proj-metadata is the edit
> >> checkbox text, so that can stay as it is.
> >>>
> >>> another thing. editing the info comment only get's applied when apply
> is
> >> pressed before ok. that's creative but not intuitive. OK implies
> >> acknowledgement, so is essentially the same as APPLY in this context.
> >>>
> >>> just took some time to add the initially requested OK button method and
> >> some more and conditionally bound that to the APPLY button. the
> ProjectInfo
> >> dialog should behave now somewhat more intuitively.
> >>>
> >>> ..ede
> >>>
> >>> On 21.05.2017 10:57, edgar.sol...@web.de wrote:
> >>>> Peppe,
> >>>>
> >>>> what about the translation strings for the user interface
> >>>> org.openjump.core.ui.plugin.file.ProjectInfoPlugIn.proj-metadata
> >>>> ?
> >>>>
> >>>> ..ede
> >>>>
> >>>> On 20.05.2017 10:42, Giuseppe Aruta wrote:
> >>>>> Hi Ede,
> >>>>> I renamed tag PROJECT_METADATA_KEY to PROJECT_COMMENT_KEY.
> >>>>>
> >>>>> Peppe
> >>>>>
> >>>>> 2017-05-11 17:46 GMT+02:00 <edgar.sol...@web.de>:
> >>>>>
> >>>>>> On 11.05.2017 17:44, Giuseppe Aruta wrote:
> >>>>>>> No problem to rename it.
> >>>>>>> Actually I am out for a couple of weeks. Can you make that
> >> modification
> >>>>>> Ede? Or we can make a list of modifications that I will do when I am
> >> back
> >>>>>> home.
> >>>>>>
> >>>>>> no stress.. the plugin is new and no release in sight. do it when
> you
> >> come
> >>>>>> around to do it ;)..
> >>>>>>
> >>>>>> ..ede
> >>>>>>
> >>>>>
> >>>>
> >>>> ------------------------------------------------------------
> >> ------------------
> >>>> Check out the vibrant tech community on one of the world's most
> >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >>>> _______________________________________________
> >>>> Jump-pilot-devel mailing list
> >>>> Jump-pilot-devel@lists.sourceforge.net
> >>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >>>>
> >>>
> >>> ------------------------------------------------------------
> >> ------------------
> >>> Check out the vibrant tech community on one of the world's most
> >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >>> _______________________________________________
> >>> Jump-pilot-devel mailing list
> >>> Jump-pilot-devel@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >>>
> >>
> >> ------------------------------------------------------------
> >> ------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> _______________________________________________
> >> Jump-pilot-devel mailing list
> >> Jump-pilot-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >>
> >
> >
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >
> >
> >
> > _______________________________________________
> > Jump-pilot-devel mailing list
> > Jump-pilot-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
