Hi, The fix seems to be good, thank you!
I have been thinking sometimes that perhaps it would be better to open SQLite databases (SpatiaLite and GeoPackage) as read only. It could prevent some locking issues and OpenJUMP does not really need read/write access. It is actually possible to update the database by using the Run database query but that is probably something that average OpenJUMP users do not even know. However, I have utilized that possibility at least for updating attributes and deleting rows from a table. Nicolas, do you have any opinion about read-only vs. read-write access? -Jukka- -----Alkuperäinen viesti----- Lähettäjä: edgar.sol...@web.de <edgar.sol...@web.de> Lähetetty: keskiviikko 12. helmikuuta 2020 16.29 Vastaanottaja: jump-pilot-devel@lists.sourceforge.net Aihe: Re: [JPP-Devel] SVN: [6238] core/trunk Jukka, can you test please?.. ede On 12.02.2020 15:23, jump-pilot-svn--- via Jump-pilot-devel wrote: > Revision: 6238 > http://sourceforge.net/p/jump-pilot/code/6238 > Author: elnico > Date: 2020-02-12 14:23:33 +0000 (Wed, 12 Feb 2020) > Log Message: > ----------- > Removed debug left at previous commit > > Modified Paths: > -------------- > core/trunk/ChangeLog > > core/trunk/src/com/vividsolutions/jump/datastore/spatialite/Spatialite > DSMetadata.java > > Modified: core/trunk/ChangeLog > =================================================================== > --- core/trunk/ChangeLog 2020-02-12 14:16:26 UTC (rev 6237) > +++ core/trunk/ChangeLog 2020-02-12 14:23:33 UTC (rev 6238) > @@ -6,6 +6,9 @@ > * Changes.txt updated until here > ********************************************** > > 2020-02-12 Nicolas Ribot > + * remove debug info left at previous commit > + > +2020-02-12 Nicolas Ribot > * fix bug in Spatialite datasources management, where spatial index query > was not built > even if a spatial index was defined on the geometric column > > > Modified: > core/trunk/src/com/vividsolutions/jump/datastore/spatialite/Spatialite > DSMetadata.java > =================================================================== > --- > core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java > 2020-02-12 14:16:26 UTC (rev 6237) > +++ > core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java > 2020-02-12 14:23:33 UTC (rev 6238) > @@ -448,7 +448,7 @@ > > public boolean isSpatialiteLoaded() { > // TODO: clean up type detection: geopackage vs spatialite > - return spatialiteLoaded || this.geometryColumnsLayout == > GeometryColumnsLayout.OGC_GEOPACKAGE_LAYOUT; > + return spatialiteLoaded; > } > > public String getSpatialiteVersion() { > > > > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
