Jevon,
Usually this kind of technical discussion should be done on the devel
mailing-list, this way other people can see what is happening.
I think lot of people will be happy with this change. You may have to edit some
JUnit tests but it's ok for me. Don't forget to add a line in the change.xml
with a big "IMPORTANT CHANGE" or something like that (it is not really an API
change).
Sourceforge trackers are reserved to external users. Feel free to fix/close
some artifacts in the tracker.
Regards,
Julien
________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : Julien HENRY <[EMAIL PROTECTED]>
Envoyé le : Mardi, 28 Octobre 2008, 9h31mn 33s
Objet : Re: About your patch
Hi Julien,
Thanks for the review and feedback! Yes, sorry about the imports changing
order, Eclipse managed to screw them up with Organise Imports, but I'll fix
this before I commit my current work.
Thanks for giving me commit rights, I've got an evening free tonight so I will
get straight into it :)
I'd like your feedback on a possible BC-breaking API change. In all of the form
element-checking asserts (such as assertFormElementPresent()), you first assert
that a form is present on the page. However, it is perfectly legal to have an
<INPUT> outside of a form element. So I'd like to remove the
assertFormPresent() check in all of these methods - but this could break
existing test cases. The other sensible alternatives are to either duplicate
all the existing methods to remove this code, or encourage element access
through XPaths etc. What do you think?
For queries like the one above, should I e-mail you directly or place them onto
the Sourceforge tracker where we can discuss it?
Cheers :)
Jevon
On Tue, Oct 28, 2008 at 9:20 PM, Julien HENRY <[EMAIL PROTECTED]> wrote:
Hi Jevon,
You patch is ok for me, the only concern I have is I think your IDE changed the
order of the imports in HtmlUnitTestingEngineImpl.java which make difficult to
know what was actually added. The implicit rule is to keep imports in
alphabetic order. In the past I tried to setup a checkstyle configuration but I
didn't conduct this task at the end. I'll try to look at it again.
I'll give you the commit rights, you can commit your patch yourself ;)
Additionnal tasks:
- add your name in the developper list in the root pom.xml
- add a description of your changes in the change.xml (next version will be
2.1)
Best regards,
Julien
________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : Julien HENRY <[EMAIL PROTECTED]>
Envoyé le : Mardi, 28 Octobre 2008, 1h56mn 03s
Objet : Re: Re : Re : JWebUnit development
Hi Julien,
Thanks for releasing JWebUnit 2.0. It looks good!
Yes, for some reason Maven has started to compile the interface properly. "mvn
install" now works fine. Perhaps it was a caching issue?
I've also worked out how the test cases are added, and attached is a patch to
test some really basic functionality of IElement. I'd like to add more to the
IElement API such as getParent() and getText(), and the related test cases.
These test cases pass with my previous patch.
Can you look at the attached patch and let me know if I can get commit rights
to SVN? Perhaps I should work solely in a branch, and occasionally one of us
can merge the changes back into trunk.
Is there a Maven command to list the available goals? Or where can I find this
information?
Cheers :)
Jevon
On Tue, Oct 28, 2008 at 3:28 AM, Julien HENRY <[EMAIL PROTECTED]> wrote:
Hi Jevon,
I've released JWebUnit 2.0. Now I will apply your patch.
Have you managed to build JWebUnit with Maven? It is very important you can
compile/run JUnit tests before contributing.
For any question regarding Maven, feel free to ask.
Regards,
Julien
________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : Julien HENRY <[EMAIL PROTECTED]>
Envoyé le : Vendredi, 24 Octobre 2008, 2h24mn 07s
Objet : Re: Re : JWebUnit development
Hi Julien,
Thanks for the quick reply. I'm keen to hopefully add a lot of useful
contributions.
Please find attached a patch to add a new method - IElement
getElementByXPath(String xpath) - as can be used on the trunk. The idea of this
method is so you can do something like this in a test case:
IElement element = getElementByXpath("//[EMAIL PROTECTED]'foo']");
assertNotNull(element);
assertEquals(element.getNodeName(), "h1");
assertEquals(element.getNodeAttribute("class"), "foo_style");
This seems an easier way to write tests, rather than (for example)
assertElementByXpathHasClass(), and for every possible attribute.
I couldn't get Maven to compile it successfully, though. For some reason the
Maven build script couldn't add:
import net.sourceforge.jwebunit.api.IElement;
to the generated WebTestCase.java. I tried adding it to the
jwebunit-webtestcase-generator/src/main/javacc/Java1.5.jj but it didn't work.
I'm not yet a Maven expert so don't yet know how to debug the build. Any ideas?
I wanted to get Maven to compile it so I could add some test cases to test the
new method.
When are you planning on releasing JWebUnit 2.0?
Cheers :)
Jevon
On Fri, Oct 24, 2008 at 12:54 AM, Julien HENRY <[EMAIL PROTECTED]> wrote:
Hi Jevon,
You're more than welcome to work on JWebUnit. I will add you to the project,
but please send me your first contribution as a patch. After reviewing the
patch and if your code quality is good, I will grant you the commit rights on
SVN.
Best regards,
Julien
----- Message d'origine ----
De : Jevon Wright <[EMAIL PROTECTED]>
À : [EMAIL PROTECTED]
Cc : [EMAIL PROTECTED]
Envoyé le : Jeudi, 23 Octobre 2008, 12h49mn 46s
Objet : JWebUnit development
Message body follows:
Hello,
I am a postgraduate student in New Zealand who is keen to
use test driven development for web applications, in
particular with JWebUnit. However as I have started working
with it I have found there are a few rough patches, and I
have also noticed that there is little activity on the SF
tracker.
Would you be interested in adding me onto the JWebUnit
project to fix bugs, add new features, address issues on the
issue tracking system and so forth?
Cheers :)
Jevon
--
This message has been sent to you, a registered SourceForge.net user,
by another site user, through the SourceForge.net site. This message
has been delivered to your SourceForge.net mail alias. You may reply
to this message using the "Reply" feature of your email client, or
using the messaging facility of SourceForge.net at:
https://sourceforge.net/sendmessage.php?touser=949547
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development
