Hello Igor,
Here is what I though about the addition of the VNCautodetection to
StartOSDetection function. I hope this will give you the idea of my concerns
regarding function execution paths.
1.. if the VNC auto detection is *one time process(Empty registry)* then
that check should be added to the code as the StartOSDetection gets called
on the new device discovery only for the devices that hasn't gone through
the OS detection process.(Some registry checking code)
2.. StartOSDetection may get called more than once if some machine joins
the LAN after kaboodle startup through Ethernet sniffer thread.
3.. If it should execute on kaboodle *startup each time* then it should
be:
If the registry has all the devices that have gone through the OS
detection then the OS detection skips those devices and hence the
nEntries may be zero in that case. In that case we do not need to update the
GUI and NID so the code should be
if (nEntries != 0 )
{
TRACE ("\n------OS detection DISPLAY ");
PostEFMessage(m_nThreadID,m_dwControllerID,MSG_UPDATE_NETWORKPCS,Buffer.Leng
th(),Buffer.GetBuffer());
}
static bool bVncAutoDetect = true;
if (bVncAutoDetect)
{
CMainFrame* pFrame = CMainFrame::GetMainFrame();
if (pFrame)
{
pFrame->PostMessage(CMainFrame::m_nMsgBeginVncAutoDetection);
bVncAutoDetect = false;
}
}
Regards,
Varsha
----- Original Message -----
From: "Igor Kotelevsky" <[EMAIL PROTECTED]>
To: "mailbox" <[EMAIL PROTECTED]>; "Scott C. Best" <[EMAIL PROTECTED]>
Cc: "Kaboodle-devel" <[EMAIL PROTECTED]>
Sent: Wednesday, July 03, 2002 7:07 PM
Subject: Re: [Kaboodle-devel] Re: Access violations
> Hello Varsha.
> I don't understand some details of your message.
> Please let me know where is valid point for starting VNC autodetection.
> - Igor
>
>
> ----- Original Message -----
> From: "mailbox" <[EMAIL PROTECTED]>
> To: "Scott C. Best" <[EMAIL PROTECTED]>
> Cc: "Igor Kotelevsky" <[EMAIL PROTECTED]>; "Kaboodle-devel"
> <[EMAIL PROTECTED]>
> Sent: Wednesday, July 03, 2002 4:38 PM
> Subject: Re: [Kaboodle-devel] Re: Access violations
>
>
> >
> >
> > Hello Scott,
> >
> > I can add the checks but I think Igor is the right person as he knows in
> > depth about the VNC autodetection.
> >
> > Regards,
> >
> > Varsha
> >
> >
> >
> >
> >
> > ----- Original Message -----
> > From: "Scott C. Best" <[EMAIL PROTECTED]>
> > To: "mailbox" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
> > Cc: "Igor Kotelevsky" <[EMAIL PROTECTED]>; "Kaboodle-devel"
> > <[EMAIL PROTECTED]>
> > Sent: Tuesday, July 02, 2002 11:05 PM
> > Subject: Re: [Kaboodle-devel] Re: Access violations
> >
> >
> > > VK:
> > > I think this sounds right:
> > >
> > > > > > 2 - I replaced the calling of "Vnc running auto detection" in
> other
> > > > > > place.
> > > > > > Now it begins after finish OS detection
> > > > > > (after closing the window "Classifying New Devices...").
> > > > > > That calling inheres in following place:
> > > > > > file SearchNetworkManager.cpp,
> > > > > > end of fuction void CSearchNetworkManager::StartOSDetection().
> > > > > > Please ask author of "LAN detection"
> > > > > > (it seems to me that author is VK)
> > > > > > really specified by me point is point of completion "LAN
> detection"
> > > > > > or no.
> > > > >
> > > > > Did Igor put the "VNC Auto Detection" kick-off in
> > > > > the right place? As above, it should go off after all of the
> > > > > OS classification is done.
> > > >
> >
>
****************************************************************************
> > > > ***************************
> > > > The place is right but
> > > > 1. if the VNC auto detection is one time process(Empty registry)
then
> > that
> > > > check should be added to the code as the StartOSDetection gets
called
> on
> > the
> > > > new device discovery only for the devices that hasn't gone through
the
> > OS
> > > > detection process.
> > >
> > > Will you be making this change, or will Igor be making this
> > > change?
> > >
> >
> >
> >
> > > -Scott
> > >
> > >
> > >
> >
> >
> >
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> No, I will not fix your computer.
> http://thinkgeek.com/sf
> _______________________________________________
> Kaboodle-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/kaboodle-devel
>
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Caffeinated soap. No kidding.
http://thinkgeek.com/sf
_______________________________________________
Kaboodle-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kaboodle-devel
