On Apr 18, 1999, Aaron Place <[EMAIL PROTECTED]> wrote:
> Could someone please commit these changes (if they are correct).
Thanks, installed most of it.
> * libraries/clib/io/RandomAccessFile.c,
> libraries/javalib/java/io/RandomAccessFile.java: change
> constructor to throw FileNotFoundException
Throwing FileNotFoundException is correct, but the method declaration
still says it throws IOException, so I did not install the .java patch.
> * libraries/javalib/java/io/StringReader.java (ready): fix
Doesn't make much sense to me; `closed' would never be `true'. Maybe
you meant to set it to `true' in close(). And then, shouldn't it be
checked in *every* method, not only in ready()?
> * libraries/javalib/java/io/StringWriter.java (StringWriter): make
> public
> (close): change signature
Nope, close() is documented as throwing IOException, we shouldn't drop
it. But maybe it shouldn't do nothing, behaving like in your proposed
change to StringReader.
> * libraries/javalib/java/text/DateFormat.java, NumberFormat.java:
> clone is handled by superclass
The docs say they *do* define clone(), they just don't explicitly
implement Cloneable. I've installed only the part that removes
Cloneable from `implements'.
Thanks!
--
Alexandre Oliva http://www.dcc.unicamp.br/~oliva IC-Unicamp, Bra[sz]il
{oliva,Alexandre.Oliva}@dcc.unicamp.br aoliva@{acm.org,computer.org}
oliva@{gnu.org,kaffe.org,{egcs,sourceware}.cygnus.com,samba.org}
*** E-mail about software projects will be forwarded to mailing lists
