[ 
https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101547#comment-13101547
 ] 

Joel Koshy commented on KAFKA-70:
---------------------------------

Prashanth,

Thanks a lot for the patch. cleanUpSegmentsToMaintainSize will walk through the 
segments in whatever order they were loaded. That is done in loadSegments which 
(due to java.io.File.listFiles) does not guarantee any particular order. We 
need to do a numeric sort of the segments and then start deleting from the 
segment with the smallest offset.

Joel


> Introduce retention setting that depends on space
> -------------------------------------------------
>
>                 Key: KAFKA-70
>                 URL: https://issues.apache.org/jira/browse/KAFKA-70
>             Project: Kafka
>          Issue Type: New Feature
>    Affects Versions: 0.8
>              Labels: log, roll
>         Attachments: KAFKA-70.patch
>
>
> Currently there is this setting: 
> log.retention.hours 
> introduce: 
> log.retention.size 
> Semantic would be, either size is reached or time is reached, oldest messages 
> will be deleted. 
> This does not break back-ward compatibility and would make the system robust 
> under scenarios where message size is not deterministic over time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to