[
https://issues.apache.org/jira/browse/KAFKA-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136201#comment-13136201
]
Neha Narkhede commented on KAFKA-171:
-------------------------------------
This is a good change to make. A couple of comments -
1. Since we are changing WritableByteChannel to GatheringByteChannel, it is
better to change the return type of writeTo and writeCompletely to return long,
instead of int. This will avoid the coercion to Int in
BoundedByteBufferSend.scala.
2. There are a couple of other places, where we do these double writes, e.g.
OffsetArraySend, MessageSetSend etc. We might as well fix those ?
> Kafka producer should do a single write to send message sets
> ------------------------------------------------------------
>
> Key: KAFKA-171
> URL: https://issues.apache.org/jira/browse/KAFKA-171
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.7, 0.8
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Fix For: 0.8
>
> Attachments: KAFKA-171-draft.patch
>
>
> From email thread:
> http://mail-archives.apache.org/mod_mbox/incubator-kafka-dev/201110.mbox/%3ccafbh0q1pyuj32thbayq29e6j4wt_mrg5suusfdegwj6rmex...@mail.gmail.com%3e
> > Before sending an actual message, kafka producer do send a (control)
> > message of 4 bytes to the server. Kafka producer always does this action
> > before send some message to the server.
> I think this is because in BoundedByteBufferSend.scala we do essentially
> channel.write(sizeBuffer)
> channel.write(dataBuffer)
> The correct solution is to use vector I/O and instead do
> channel.write(Array(sizeBuffer, dataBuffer))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
