[ https://issues.apache.org/jira/browse/KAFKA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139814#comment-13139814 ]
Neha Narkhede commented on KAFKA-176: ------------------------------------- This is a draft patch, so things that I wasn't sure off, are left incomplete 1. The header being in debug logging is clearly not ideal. There are 2 ways of exposing the header - a. In the code b. In the scripts Since some graphing tools might need the headers in a certain format, I initially thought its better left in the scripts (see KAFKA-175). However, since the code controls the display of the data, it might as well be left there. 2. The --avg option already controls that. We could probably rename that to -aggregate instead ? 3.1 & 3.2 The reason I haven't touched the variable size message path is because I don't think it is well implemented. When selecting that option, the throughput actually reduces due to the way it is implemented. Not sure having a variable message size option actually helps conclude anything in this perf test ? 4. Good point. I will update the patch, once we have a better idea about the questions above. > Fix existing perf tools > ----------------------- > > Key: KAFKA-176 > URL: https://issues.apache.org/jira/browse/KAFKA-176 > Project: Kafka > Issue Type: Sub-task > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Fix For: 0.8 > > Attachments: kafka-176.patch > > > The existing perf tools - ProducerPerformance.scala, > ConsumerPerformance.scala and SimpleConsumerPerformance.scala are slightly > buggy. It will be good to - > 1. move them to a perf directory from the existing kafka/tools location > 2. fix the bugs, so that they measure throughput correctly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira