[ 
https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183581#comment-13183581
 ] 

Joe Stein commented on KAFKA-240:
---------------------------------

so I started looking at parts of the code and the document

there still seems to be an open question in regards to breaking change or not

I think there is a lot of benefit to not have a breaking change granted the 
code will get a bit cluttered but nice that we can add the new class (i.e. 
WireProducerRequest) in the same file as ProducerRequest and the internal guts 
and works (as suggested in the wiki "One thought on this is that it is probably 
not too hard to make most of the above changes as new request types and map the 
old request types to the new")

I do not understand the next line though "However if we are changing the 
request id and version id scheme then this will likely not be possible."

keeping the old format would be helpful in upgrades and existing clients being 
able to operate without changes.

assuming that (and would like clarification on "However if we are changing the 
request id and version id scheme then this will likely not be possible.") then 
we would should agree on the naming for the new extended Request/Response 
format (e.g. WireXYZRequest WireXYZResponse) or something else besides Wire (I 
don't really like that but first thing that came to me without much thinking 
about it) but something to help denote the internal communications from 
component to component and have all those classes start the same).





                
> implement new producer and consumer request format
> --------------------------------------------------
>
>                 Key: KAFKA-240
>                 URL: https://issues.apache.org/jira/browse/KAFKA-240
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>            Reporter: Jun Rao
>             Fix For: 0.8
>
>
> We want to change the producer/consumer request/response format according to 
> the discussion in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to