[
https://issues.apache.org/jira/browse/KAFKA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184720#comment-13184720
]
Neha Narkhede commented on KAFKA-244:
-------------------------------------
Thanks for uploading the patch. A couple of comments -
1. As part of adding the broker.list and zk.connect options, it will be a good
idea to get rid of host and port usage in the log4j appender
2. If both zk.connect and broker.list options are specified, maybe throwing an
InvalidConfigException would be good, specifying that only one option should be
set.
3. Also, it will be good to add tests to test the zk.connect option in the
log4j appender.
> Improve log4j appender to use kafka.producer.Producer, and support
> zk.connect|broker.list options
> ---------------------------------------------------------------------------------------------------
>
> Key: KAFKA-244
> URL: https://issues.apache.org/jira/browse/KAFKA-244
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 0.7.1
> Reporter: Stefano Santoro
> Labels: log4j, newbie
> Fix For: 0.7.1
>
> Attachments: Log4jAppender.patch
>
>
> Taken from #kafka IRC session with Neha Narkhede:
> The log4j appender is quite obsolete, there are a few things to change there.
> Make it use the kafka.producer.Producer instead of SyncProducer. That allows
> you to use either the broker.list or the zk.connect option
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
