[ 
https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202586#comment-13202586
 ] 

Jay Kreps commented on KAFKA-240:
---------------------------------

Hey Prashanth, this is great. Question do we need a builder class for 
FetchRequest versus just using named arguments? It doesn't make a big 
difference but it would probably be good for us to agree on a pattern and carry 
it forward for all the various requests. With named arguments presumably it 
would be something like:

new FetchRequest(correlationId = 2345454, versionId = 2, ...)
                
> implement new producer and consumer request format
> --------------------------------------------------
>
>                 Key: KAFKA-240
>                 URL: https://issues.apache.org/jira/browse/KAFKA-240
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>              Labels: fetch, replication, wireprotocol
>             Fix For: 0.8
>
>         Attachments: KAFKA-240-FetchRequest-v1.patch
>
>
> We want to change the producer/consumer request/response format according to 
> the discussion in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to