[
https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206046#comment-13206046
]
Joe Stein edited comment on KAFKA-240 at 2/11/12 6:59 AM:
----------------------------------------------------------
here is v3 patch for ProducerRequest changes and ProducerResponse also
inclusive of v2 changes for Fetch
note a few things
1) I did not integrate the topic & partition data classes from our two changes,
I ran into a bump with not being able to get the buffer from the abstract
MessageSet and figured we can do this later wanted to get this up and reviewed
see if anything else is left. Prashanth if you have some ideas here let me know
2) There is still a failed test in AsyncPoolTest
3) I was not sure what to-do with errors and offsets in KafkaApi
handleProducerRequest in building the ProducerResponse for what the values
should be in that block
was (Author: charmalloc):
here is v3 patch inclusive of v2 changes for Fetch
note a few things
1) I did not integrate the topic & partition data classes from our two changes,
I ran into a bump with not being able to get the buffer from the abstract
MessageSet and figured we can do this later wanted to get this up and reviewed
see if anything else is left. Prashanth if you have some ideas here let me know
2) There is still a failed test in AsyncPoolTest
3) I was not sure what to-do with errors and offsets in KafkaApi
handleProducerRequest in building the ProducerResponse for what the values
should be in that block
> implement new producer and consumer request format
> --------------------------------------------------
>
> Key: KAFKA-240
> URL: https://issues.apache.org/jira/browse/KAFKA-240
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: fetch, replication, wireprotocol
> Fix For: 0.8
>
> Attachments: KAFKA-240-FetchRequest-v1.patch,
> KAFKA-240-FetchRequest-v2.patch, KAFKA-240.v3.patch
>
>
> We want to change the producer/consumer request/response format according to
> the discussion in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
