[
https://issues.apache.org/jira/browse/KAFKA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212329#comment-13212329
]
Jun Rao commented on KAFKA-48:
------------------------------
Overall, the patch looks good. Some comments:
1. DelayedItem.compareTo: yourEnd should be delayed.createdMs + delayed.delayMs
2. Suppose that a client issues MultiFetch requests on a hot topic and a cold
topic. What can happen is that the watcher list for the cold topic won't be
cleaned up for a long time. One solution is to have a cleaner thread that
periodically wakes up to remove satisfied items. The cleaner thread can be used
to clean up the DelayQueue too.
3. MessageSetSend.empty is not used.
> Implement optional "long poll" support in fetch request
> -------------------------------------------------------
>
> Key: KAFKA-48
> URL: https://issues.apache.org/jira/browse/KAFKA-48
> Project: Kafka
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Jay Kreps
> Attachments: KAFKA-48.patch
>
>
> Currently, the fetch request is non-blocking. If there is nothing on the
> broker for the consumer to retrieve, the broker simply returns an empty set
> to the consumer. This can be inefficient, if you want to ensure low-latency
> because you keep polling over and over. We should make a blocking version of
> the fetch request so that the fetch request is not returned until the broker
> has at least one message for the fetcher or some timeout passes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
