[ 
https://issues.apache.org/jira/browse/KAFKA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252909#comment-13252909
 ] 

Jay Kreps commented on KAFKA-246:
---------------------------------

Thanks for the patch!

I wonder if instead of adding a logging statement for each value which is a 
little repetitive we could instead do the following:
Create a Props object that wraps Properties and has helpers like getInt,  
getString, etc. Something like this: 
https://github.com/voldemort/voldemort/blob/master/src/java/voldemort/utils/Props.java
Then add something internal to this helper that records whether a given 
property is used or not (i.e. a property is used if the get method is called 
for that key). This class could be used to log out all configuration in a 
single place and also could log WARN messages for any properties that are not 
used (since that is likely a typo).

                
> log configuration values used
> -----------------------------
>
>                 Key: KAFKA-246
>                 URL: https://issues.apache.org/jira/browse/KAFKA-246
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>              Labels: newbie
>         Attachments: KAFKA-246-broker-0.8.patch
>
>
> Currently, it's hard to figure out which configuration value is being used 
> and whether a new configuration is being picked up. Logging all configuration 
> values during startup time can address this issue. We should cover broker, 
> producer and consumer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to