[
https://issues.apache.org/jira/browse/KAFKA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281133#comment-13281133
]
Jun Rao commented on KAFKA-336:
-------------------------------
Thanks for the new patch. Some comments:
>From previous review:
#2.2. from my comment and #4 from Jay's comment are still not addressed.
New review comments:
11. It seems that we haven't really documented the exact format of the new
requests and the responses. I documented them in
https://cwiki.apache.org/confluence/display/KAFKA/kafka+Detailed+Replication+Design+V3
. Does it make sense? If so, this would require some changes in this patch.
12. KafkaZookeeper, KafkaApis: For this patch, we can just add a TODO comment
in the handler in KafkaApis) and simply send a dummy response (with eror_code
= 0). We can remove the code in KafkaZookeeper since the handler probably
shouldn't in KafkaZookeeper when it's actually put in.
13. Are the changes in Partition and Replica still necessary if #12 is resolved?
For Jay's comment, for now, it seems that we just need to add a couple of new
types of request. So, we can probably start with customized request objects.
> add an admin RPC to communicate state changes between the controller and the
> broker
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-336
> URL: https://issues.apache.org/jira/browse/KAFKA-336
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Yang Ye
> Fix For: 0.8
>
> Attachments: controller_broker_RPC.patch, rpc.patch.v2
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
> Based on the discussion in
> https://cwiki.apache.org/confluence/display/KAFKA/kafka+Detailed+Replication+Design+V3
> , it's more efficient to communicate state change commands between the
> controller and the broker using a direct RPC than via ZK. This ticket will be
> implementing an admin RPC client for the controller to send state change
> commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
