[ 
https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neha Narkhede updated KAFKA-46:
-------------------------------

    Attachment: kafka-46-v3.patch

Updated patch to address Jun's suggestions -

1. Fixed the ISR expiration for stuck followers case
2. HW maintenance work is postponed to KAFKA-350
3. System test (KAFKA-341), that tests message replication without failures, 
works on this patch

More detailed comments -

21. Removed it

22. Partition.getOutOfSyncReplicas(): Good catch ! Fixed the logic and added 
another test case for this.

23. ReplicaManager: Done

24. Replica: Changed the name to logEndOffsetUpdateTime()

25. KafkaConfig: Changed the variable and config names to replica.*

26. KafkaServer: Well, become* makes sense on the entity that is changing its 
state (Replica), make*, I thought made sense on the actor (KafkaServer). But 
that is just a matter of personal taste :)

27. There are some nitty gritty details about HW maintenance that I would like 
to fix as part of KAFKA-350

28. ISRExpirationTest: Done

29. PrimitiveApiTest.testConsumerNotExistTopic(): I think the right fix is to 
throw a descriptive exception is UnknownTopicException when a client makes a 
produce/consume request for a topic that has never been created. Filed 
KAFKA-351 to fix it.

30. TestUtils:Fixed it
                
> Commit thread, ReplicaFetcherThread for intra-cluster replication
> -----------------------------------------------------------------
>
>                 Key: KAFKA-46
>                 URL: https://issues.apache.org/jira/browse/KAFKA-46
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jun Rao
>            Assignee: Neha Narkhede
>         Attachments: kafka-46-draft.patch, kafka-46-v1.patch, 
> kafka-46-v2.patch, kafka-46-v3.patch
>
>
> We need to implement the commit thread at the leader and the fetcher thread 
> at the follower for replication the data from the leader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to