[
https://issues.apache.org/jira/browse/KAFKA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397691#comment-13397691
]
Jun Rao commented on KAFKA-306:
-------------------------------
Thanks for patch v2. Some comments:
21. run_test.sh
21.1 Does the following check in start_test() need to be repeated for source,
mirror and target, or can we just use 1 check for all 3 cases?
if [[ $num_iterations -ge $iter && $svr_idx -gt 0 ]]; then
echo
info "=========================================="
info "Iteration $iter of ${num_iterations}"
info "=========================================="
21.2 Do we need to sleep for 30s at the end start_test()? Isn't calling
wait_for_zero_consumer_lags enough? Also, the comment says sleep for 10s.
21.3 In the header, we should add that mirror make can be terminated too.
21.4 If the test fails, could we generate a list of missing messages in a file?
Ideally, messages can just be strings with sequential numbers in them.
22. The following test seems to fail sometimes.
bin/run-test.sh 2 23
23. README: We should add that one needs to do ./sbt package at the root level
first.
> broker failure system test broken on replication branch
> -------------------------------------------------------
>
> Key: KAFKA-306
> URL: https://issues.apache.org/jira/browse/KAFKA-306
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: John Fung
> Labels: replication
> Attachments: kafka-306-v1.patch, kafka-306-v2.patch
>
>
> The system test in system_test/broker_failure is broken on the replication
> branch. This test is a pretty useful failure injection test that exercises
> the consumer rebalancing feature, various replication features like leader
> election. It will be good to have this test fixed as well as run on every
> checkin to the replication branch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
