[ https://issues.apache.org/jira/browse/KAFKA-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397783#comment-13397783 ]
Joel Koshy commented on KAFKA-339: ---------------------------------- +1 on v2 Minor comments: - AbstractFetcherManager: may be useful to log the fetcher-id for the topic/partition when adding the fetcher - ReplicaFetcherManager: miss-match -> mismatch - ReplicaManager: makeFollower: I still don't think we need to look up zk for the leader as the value passed in should be current. > using MultiFetch in the follower > -------------------------------- > > Key: KAFKA-339 > URL: https://issues.apache.org/jira/browse/KAFKA-339 > Project: Kafka > Issue Type: Sub-task > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Assignee: Jun Rao > Fix For: 0.8 > > Attachments: kafka-339_v1.patch, kafka-339_v2.patch > > Original Estimate: 252h > Remaining Estimate: 252h > > A broker could be following multiple topic/partitions from the broker. > Instead of using 1 fetcher thread per topic/partition, it would be more > efficient to use 1 fetcher thread that issues multi-fetch requests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira