[
https://issues.apache.org/jira/browse/KAFKA-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403640#comment-13403640
]
Jun Rao commented on KAFKA-353:
-------------------------------
A few more comments on patch v3:
31. DelayedProduce.isSatisfied():
31.1 We iterate leader.partition.inSyncReplicas here. However, ISR can be
updated concurrently. We probably need to make leader.partition.inSyncReplicas
an AtomicReference.
31.2 Could you add a comment that explains what produce.requiredAcks < 0 means?
For the race condition between expire() and checkSatisfied, I agree that it's
probably easier if RequestPurgatory does the synchronization on DelayedRequest.
> tie producer-side ack with high watermark and progress of replicas
> ------------------------------------------------------------------
>
> Key: KAFKA-353
> URL: https://issues.apache.org/jira/browse/KAFKA-353
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Joel Koshy
> Attachments: kafka-353_v1.patch, kafka-353_v2.patch,
> kafka-353_v2_to_v3.patch, kafka-353_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
